mirror of
https://github.com/nushell/nushell.git
synced 2025-06-20 01:48:09 +02:00
create a better error message for bad glob patterns (#13613)
# Description @sholderbach pointed out that I could've made this error message better. So, here's my attempt to make it better. This should work. I had a hard time figuring out how to trigger the error anyway because the type checker doesn't allow "bad" parameters to begin with. ### Before  ### After  # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
parent
4732507f46
commit
f122065772
@ -148,7 +148,8 @@ impl Command for Glob {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
let glob_pattern = match glob_pattern_input {
|
let glob_pattern =
|
||||||
|
match glob_pattern_input {
|
||||||
Value::String { val, .. } => {
|
Value::String { val, .. } => {
|
||||||
if val.is_empty() {
|
if val.is_empty() {
|
||||||
return Err(ShellError::GenericError {
|
return Err(ShellError::GenericError {
|
||||||
@ -175,12 +176,12 @@ impl Command for Glob {
|
|||||||
val
|
val
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
_ => {
|
_ => return Err(ShellError::IncorrectValue {
|
||||||
return Err(ShellError::IncompatibleParametersSingle {
|
msg: "Incorrect glob pattern supplied to glob. Please use string or glob only."
|
||||||
msg: "Incorrect parameter type".to_string(),
|
.to_string(),
|
||||||
span: glob_span,
|
val_span: call.head,
|
||||||
})
|
call_span: glob_span,
|
||||||
}
|
}),
|
||||||
};
|
};
|
||||||
|
|
||||||
let folder_depth = if let Some(depth) = depth {
|
let folder_depth = if let Some(depth) = depth {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user