mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 06:30:08 +02:00
Disallow ^
in def
command names (#7606)
# Description Closes #7273. Also slightly edits/tidies up parser.rs. # User-Facing Changes `^` is now forbidden in `def` and `def-env` command names. EDIT: also `alias`. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -28,38 +28,33 @@ fn def_errors_with_multiple_short_flags() {
|
||||
"#
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("expected one short flag"));
|
||||
assert!(actual.err.contains("expected only one short flag"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn def_fails_with_invalid_name() {
|
||||
let err_msg = "command name can't be a number, a filesize, or contain a hash # or caret ^";
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
cwd: ".", pipeline(
|
||||
r#"
|
||||
def 1234 = echo "test"
|
||||
"#
|
||||
));
|
||||
assert!(actual
|
||||
.err
|
||||
.contains("command name can't be a number, a filesize, or contain a hash"));
|
||||
assert!(actual.err.contains(err_msg));
|
||||
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
cwd: ".", pipeline(
|
||||
r#"
|
||||
def 5gib = echo "test"
|
||||
"#
|
||||
));
|
||||
assert!(actual
|
||||
.err
|
||||
.contains("command name can't be a number, a filesize, or contain a hash"));
|
||||
assert!(actual.err.contains(err_msg));
|
||||
|
||||
let actual = nu!(
|
||||
cwd: "tests/fixtures/formats", pipeline(
|
||||
cwd: ".", pipeline(
|
||||
r#"
|
||||
def "te#t" = echo "test"
|
||||
def ^foo [] {}
|
||||
"#
|
||||
));
|
||||
assert!(actual
|
||||
.err
|
||||
.contains("command name can't be a number, a filesize, or contain a hash"));
|
||||
assert!(actual.err.contains(err_msg));
|
||||
}
|
||||
|
Reference in New Issue
Block a user