extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-28 19:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix inaccurate sleep duration (#12235)

Browse Source 
# Description
Improves the accuracy of sleep when the duration is larger than 100ms.
Fixes #12223.

# User-Facing Changes
Sleeping for 150ms should work now.

```nushell
~/nushell> timeit { sleep 150ms }                                                                                                                                          03/19/2024 10:41:55 AM AM
151ms 344µs 201ns
```
This commit is contained in:
YizhePKU 2024-03-20 16:45:33 +08:00 committed by GitHub
parent f56070cbcd
commit f8c1e03ea7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crates/nu-command/src/platform/sleep.rs
View File

@ -52,16 +52,17 @@ impl Command for Sleep {
let total_dur = let total_dur =
duration_from_i64(duration) + rest.into_iter().map(duration_from_i64).sum::<Duration>(); duration_from_i64(duration) + rest.into_iter().map(duration_from_i64).sum::<Duration>();
let deadline = Instant::now() + total_dur;
let ctrlc_ref = &engine_state.ctrlc.clone();
let start = Instant::now();
loop { loop {
thread::sleep(CTRL_C_CHECK_INTERVAL.min(total_dur)); // sleep for 100ms, or until the deadline
if start.elapsed() >= total_dur { let time_until_deadline = deadline.saturating_duration_since(Instant::now());
if time_until_deadline.is_zero() {
break; break;
} }
thread::sleep(CTRL_C_CHECK_INTERVAL.min(time_until_deadline));
if nu_utils::ctrl_c::was_pressed(ctrlc_ref) { // exit early if Ctrl+C was pressed
if nu_utils::ctrl_c::was_pressed(&engine_state.ctrlc) {
return Err(ShellError::InterruptedByUser { return Err(ShellError::InterruptedByUser {
span: Some(call.head), span: Some(call.head),
}); });