extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-12-23 15:39:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Categorification: move uncategorized String commands to Category::Strings (#9931)

Browse Source 
In an effort to go through and review all of the remaining commands to
find anything else that could possibly
be moved to *nu-cmd-extra*

I noticed that there are still some commands that have not been
categorized...

I am going to *Categorize* the remaining commands that still *do not
have Category homes*

In PR land I will call this *Categorification* as a play off of
*Cratification*

* str substring
* str trim
* str upcase

were in the *default* category because for some reason they had not yet
been categorized.
I went ahead and moved them to the

```rust
.category(Category::Strings)
```
This commit is contained in:
Michael Angerman 2023-08-06 09:08:45 -07:00 committed by GitHub
parent 58f98a4260
commit fa2d9a8a58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/nu-command/src/strings/str_/case/upcase.rs
View File

@ -2,6 +2,7 @@ use nu_engine::CallExt;
use nu_protocol::ast::Call;
use nu_protocol::ast::CellPath;
use nu_protocol::engine::{Command, EngineState, Stack};
use nu_protocol::Category;
use nu_protocol::{Example, PipelineData, ShellError, Signature, Span, SyntaxShape, Type, Value};
#[derive(Clone)]
@ -29,6 +30,7 @@ impl Command for SubCommand {
SyntaxShape::CellPath,
"For a data structure input, convert strings at the given cell paths",
)
.category(Category::Strings)
}
fn usage(&self) -> &str {

2
crates/nu-command/src/strings/str_/substring.rs
View File

@ -5,6 +5,7 @@ use nu_engine::CallExt;
use nu_protocol::ast::Call;
use nu_protocol::ast::CellPath;
use nu_protocol::engine::{Command, EngineState, Stack};
use nu_protocol::Category;
use nu_protocol::{
Example, PipelineData, Range, ShellError, Signature, Span, SyntaxShape, Type, Value,
};
@ -69,6 +70,7 @@ impl Command for SubCommand {
SyntaxShape::CellPath,
"For a data structure input, turn strings at the given cell paths into substrings",
)
.category(Category::Strings)
}
fn usage(&self) -> &str {

2
crates/nu-command/src/strings/str_/trim/trim_.rs
View File

@ -1,5 +1,6 @@
use nu_cmd_base::input_handler::{operate, CmdArgument};
use nu_engine::CallExt;
use nu_protocol::Category;
use nu_protocol::{
ast::{Call, CellPath},
engine::{Command, EngineState, Stack},
@ -66,6 +67,7 @@ impl Command for SubCommand {
"trims characters only from the end of the string",
Some('r'),
)
.category(Category::Strings)
}
fn usage(&self) -> &str {
"Trim whitespace or specific character."