mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 17:25:15 +02:00
fix(std/help): trim example results and fix binary examples (#16354)
# Description Added trimming to the example results like in the normal `help`, and also changed the logic for binary examples to remove the weird spacing. - Before: <img width="998" height="919" alt="image" src="https://github.com/user-attachments/assets/03f18f45-5b12-41bc-b495-232bcf899964" /> - After: <img width="959" height="720" alt="image" src="https://github.com/user-attachments/assets/894dc622-c603-467c-8904-aef582a82b0a" /> # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -708,8 +708,9 @@ def build-command-page [command: record] {
|
||||
(if not ($example.result | is-empty) {
|
||||
$example.result
|
||||
| table -e
|
||||
| to text
|
||||
| if ($example.result | describe) == "binary" { str join } else { lines }
|
||||
| str trim --right
|
||||
| lines
|
||||
| skip until { is-not-empty }
|
||||
| each {|line|
|
||||
$" ($line)"
|
||||
}
|
||||
|
Reference in New Issue
Block a user