mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 14:40:06 +02:00
allow int as a cellpath for select
(#10048)
Description This PR allows ints to be used as cell paths. ### Before ```nushell ❯ let index = 0 ❯ locations | select $index Error: nu:🐚:cant_convert × Can't convert to cell path. ╭─[entry #26:1:1] 1 │ locations | select $index · ───┬── · ╰── can't convert int to cell path ╰──── ``` ### After ```nushell ❯ let index = 0 ❯ locations | select $index ╭#┬───────location────────┬city_column┬state_column┬country_column┬lat_column┬lon_column╮ │0│http://ip-api.com/json/│city │region │countryCode │lat │lon │ ╰─┴───────────────────────┴───────────┴────────────┴──────────────┴──────────┴──────────╯ ``` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -264,3 +264,11 @@ fn select_rows_with_variable_list() {
|
||||
|
||||
assert_eq!(actual.out, "[[a, b, c]; [1, 2, 3], [7, 8, 9]]");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn select_single_row_with_variable() {
|
||||
let actual = nu!("let idx = 2;[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select $idx | to nuon");
|
||||
|
||||
assert_eq!(actual.out, "[[a]; [3]]".to_string());
|
||||
assert!(actual.err.is_empty());
|
||||
}
|
||||
|
Reference in New Issue
Block a user