extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-26 02:13:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes insecure and timeout flags (#8255)

Browse Source 
# Description

Fixes #8098 by properly parsing `insecure` flag and also fixes the
`timeout` flag, which is described as `max-time` (from curl?).

# User-Facing Changes

The only change is that the flags now work.

# Tests + Formatting

Everything passes.

# Screenshots

Before

![image](https://user-images.githubusercontent.com/4399118/221845043-6dfba69d-daea-49a7-b55c-7ee628551b1c.png)

After


![image](https://user-images.githubusercontent.com/4399118/221845382-0111cbe9-4ba6-4de1-9e2a-655efbc65a26.png)
This commit is contained in:
alesito85 2023-02-28 13:48:15 +01:00 committed by GitHub
parent b093d5d10d
commit ffc3727a1e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/nu-command/src/network/http/get.rs
View File

@ -140,7 +140,7 @@ struct Arguments {
content_type: Option<String>, content_type: Option<String>,
content_length: Option<String>, content_length: Option<String>,
raw: bool, raw: bool,
insecure: Option<bool>, insecure: bool,
user: Option<String>, user: Option<String>,
password: Option<String>, password: Option<String>,
timeout: Option<Value>, timeout: Option<Value>,
@ -159,10 +159,10 @@ fn run_get(
content_type: call.get_flag(engine_state, stack, "content-type")?, content_type: call.get_flag(engine_state, stack, "content-type")?,
content_length: call.get_flag(engine_state, stack, "content-length")?, content_length: call.get_flag(engine_state, stack, "content-length")?,
raw: call.has_flag("raw"), raw: call.has_flag("raw"),
insecure: call.get_flag(engine_state, stack, "insecure")?, insecure: call.has_flag("insecure"),
user: call.get_flag(engine_state, stack, "user")?, user: call.get_flag(engine_state, stack, "user")?,
password: call.get_flag(engine_state, stack, "password")?, password: call.get_flag(engine_state, stack, "password")?,
timeout: call.get_flag(engine_state, stack, "timeout")?, timeout: call.get_flag(engine_state, stack, "max-time")?,
}; };
helper(engine_state, stack, call, args) helper(engine_state, stack, call, args)
} }
@ -178,7 +178,7 @@ fn helper(
let span = args.url.span()?; let span = args.url.span()?;
let (requested_url, url) = http_parse_url(call, span, args.url)?; let (requested_url, url) = http_parse_url(call, span, args.url)?;
let client = http_client(args.insecure.is_some()); let client = http_client(args.insecure);
let mut request = client.get(url); let mut request = client.get(url);
if let Some(data) = args.data { if let Some(data) = args.data {