Saurabh Shinde
0c72f881a6
Fix Docker image build failure ( #13938 )
...
## Description
While building the docker image under `nushell/docker` directory,
following build failure observed.
![nushell-docker-error](https://github.com/user-attachments/assets/972048d7-b001-4325-b947-93e95b98f4d1 )
The problem here is the following lines of code that decide which
`nushell` binary to download, extract, and install
https://github.com/nushell/nushell/blob/main/docker/Dockerfile#L16-L19
The issue is especially with wildcard asterisk (*) which downloads both
`amd64` and `arm64` binary while building.
## Fix
Introduced build arg `TARGETARCH` which will be populated implicitly by
docker `build/buildx` which will help us to decide which binary to
download.
## User-Facing Changes
None.
## Testing Details
Tested building docker image on both `amd64` and `arm64` systems.
**amd64/x86_64**
![nushell-docker-amd64](https://github.com/user-attachments/assets/ea30b7e3-0664-4a5b-bb13-4c18cdae2a31 )
**arm64**
![nushell-docker-arm64](https://github.com/user-attachments/assets/54e47051-1ee7-4695-bc6c-1e211532a545 )
2024-09-26 09:57:37 -05:00
Justin Ma
c9cb62067c
Fix dockerfile and reset Nu config to default ( #13851 )
...
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword ),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
Fix dockerfile and reset Nu config to default, fetching config file from
the remote may cause compatible issues
2024-09-15 20:03:22 +08:00
Andy Gayton
b27cd70fd1
remove the deprecated register
command ( #13297 )
...
# Description
This PR removes the `register` command which has been
[deprecated](https://www.nushell.sh/blog/2024-04-30-nushell_0_93_0.html#register-toc )
in favor of [`plugin
add`](https://www.nushell.sh/blog/2024-04-30-nushell_0_93_0.html#redesigned-plugin-management-commands-toc )
# User-Facing Changes
`register` is no longer available
2024-07-05 07:16:50 -05:00
Justin Ma
b03ef56bcb
Fix alpine docker file ( #10992 )
...
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword ),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
Fix docker file. For more detail see:
https://github.com/nushell/nushell/issues/8307
2023-11-08 06:30:34 -06:00
Yethal
b44926d597
Pre-register plugins inside docker container ( #9533 )
...
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword ),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
Plugins bundled with nushell will be kept inside docker container and
preregistered
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the
standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io ) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2023-06-28 13:04:32 -05:00
metacoma
7e2781a2af
fix docker build ( #7422 )
...
# Description
Docker build fails with the latest release 0.72.1
```bash
Sending build context to Docker daemon 3.072kB
Step 1/6 : FROM alpine
---> 49176f190c7e
Step 2/6 : LABEL maintainer=nushell
---> Using cache
---> 7afa6864f008
Step 3/6 : RUN echo '/usr/bin/nu' >> /etc/shells && adduser -D -s /usr/bin/nu nushell && mkdir -p /home/nushell/.config/nushell/ && wget -q https://raw.githubusercontent.com/nushell/nushell/main/crates/nu-utils/src/sample_config/default_config.nu -O /home/nushell/.config/nushell/config.nu && wget -q https://raw.githubusercontent.com/nushell/nushell/main/crates/nu-utils/src/sample_config/default_env.nu -O /home/nushell/.config/nushell/env.nu && cd /tmp && wget -qO - https://api.github.com/repos/nushell/nushell/releases/latest |grep browser_download_url |grep musl |cut -f4 -d '"' |xargs -I{} wget {} && tar -xzf nu* && chmod +x nu && mv nu /usr/bin/nu && chown -R nushell:nushell /home/nushell/.config/nushell && rm -rf /tmp/*
---> Running in fa544239a3ea
Connecting to github.com (140.82.121.4:443)
Connecting to objects.githubusercontent.com (185.199.108.133:443)
saving to 'nu-0.72.1-x86_64-unknown-linux-musl.tar.gz'
nu-0.72.1-x86_64-unk 3% |* | 552k 0:00:29 ETA
nu-0.72.1-x86_64-unk 93% |***************************** | 15.2M 0:00:00 ETA
nu-0.72.1-x86_64-unk 100% |********************************| 16.2M 0:00:00 ETA
'nu-0.72.1-x86_64-unknown-linux-musl.tar.gz' saved
chmod: nu: No such file or directory
```
2022-12-10 09:22:23 -06:00
pwygab
01386f4d58
adds a config reset
command ( #6149 )
...
* moves config files to nu_utils
* fmt
* fix dockerfile
* fix docs
2022-07-31 20:44:33 -05:00
Yethal
6ee13126f7
Update Dockerfile ( #5910 )
...
Container now uses unpriviledged user with UID 1000 by default
Container now uses Alpine as base
Final image size dropped to just 67MB
2022-06-29 18:36:24 -05:00
Justin Ma
848ff8453b
feat: Update dockerfile for latest nu release ( #5843 )
2022-06-21 18:28:31 +08:00
Justin Ma
257290acc2
Add a dockerfile example based on debian bullseye-slim ( #5176 )
...
* feat: add nu dockerfile, based on debian bullseye
* use aria2 instead of wget for bad network
* some small fix
2022-04-13 14:48:54 +03:00
JT
cdc8e67d61
Remove unused repo parts ( #4271 )
...
* Remove unused repo parts
* Update README
* cargo fmt
2022-01-26 07:31:04 +11:00
Ryuichi Watanabe
de5cd4ec23
Fix Dockerfile (cache clear of apt) ( #2394 )
2020-08-24 05:24:49 +12:00
Vanessa Sochat
6fe211fdbe
changing base image to use updated libssl, adding tests to run --help for nu
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-09-12 12:46:16 -04:00
Vanessa Sochat
1f3f3d3105
adding missing docker dependencies openssl and pkgconfig
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-09-11 13:44:23 -04:00
Vanessa Sochat
24ba0d93c7
test building akin to azure-pipelines (without release) to hopefully shorten circleci builds
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-09-08 15:44:52 -04:00
Vanessa Sochat
2983fc1dea
so close, needed to have quay.io as from image base (not docker hub)
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-08-29 20:56:48 -04:00
Vanessa Sochat
6d0ea5eda4
updating README to include instructions and link for quay.io, and removing multistage build for devel branch
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-08-29 18:45:24 -04:00
Vanessa Sochat
2bae2b57ee
adding two Dockerfiles, one for base image and the other for multistage build, and circleci config to test
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-08-27 17:58:45 -04:00