mirror of
https://github.com/nushell/nushell.git
synced 2025-02-16 10:32:29 +01:00
62e56d3581
# Description This PR adds two new `ParseError` and `ShellError` cases for type errors relating to operators. - `OperatorUnsupportedType` is used when a type is not supported by an operator in any way, shape, or form. E.g., `+` does not support `bool`. - `OperatorIncompatibleTypes` is used when a operator is used with types it supports, but the combination of types provided cannot be used together. E.g., `filesize + duration` is not a valid combination. The other preexisting error cases related to operators have been removed and replaced with the new ones above. Namely: - `ShellError::OperatorMismatch` - `ShellError::UnsupportedOperator` - `ParseError::UnsupportedOperationLHS` - `ParseError::UnsupportedOperationRHS` - `ParseError::UnsupportedOperationTernary` # User-Facing Changes - `help operators` now lists the precedence of `not` as 55 instead of 0 (above the other boolean operators). Fixes #13675. - `math median` and `math mode` now ignore NaN values so that `[NaN NaN] | math median` and `[NaN NaN] | math mode` no longer trigger a type error. Instead, it's now an empty input error. Fixing this in earnest can be left for a future PR. - Comparisons with `nan` now return false instead of causing an error. E.g., `1 == nan` is now `false`. - All the operator type errors have been standardized and reworked. In particular, they can now have a help message, which is currently used for types errors relating to `++`. ```nu [1] ++ 2 ``` ``` Error: nu::parser::operator_unsupported_type × The '++' operator does not work on values of type 'int'. ╭─[entry #1:1:5] 1 │ [1] ++ 2 · ─┬ ┬ · │ ╰── int · ╰── does not support 'int' ╰──── help: if you meant to append a value to a list or a record to a table, use the `append` command or wrap the value in a list. For example: `$list ++ $value` should be `$list ++ [$value]` or `$list | append $value`. ```
130 lines
2.9 KiB
Rust
130 lines
2.9 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn reduce_table_column() {
|
|
let actual = nu!(pipeline(
|
|
r#"
|
|
echo "[{month:2,total:30}, {month:3,total:10}, {month:4,total:3}, {month:5,total:60}]"
|
|
| from json
|
|
| get total
|
|
| reduce --fold 20 { |it, acc| $it + $acc ** 1.05}
|
|
| into string -d 1
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "180.6");
|
|
}
|
|
|
|
#[test]
|
|
fn reduce_table_column_with_path() {
|
|
let actual = nu!(pipeline(
|
|
"
|
|
[{month:2,total:30}, {month:3,total:10}, {month:4,total:3}, {month:5,total:60}]
|
|
| reduce --fold 20 { |it, acc| $it.total + $acc ** 1.05}
|
|
| into string -d 1
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "180.6");
|
|
}
|
|
|
|
#[test]
|
|
fn reduce_rows_example() {
|
|
let actual = nu!(pipeline(
|
|
"
|
|
[[a,b]; [1,2] [3,4]]
|
|
| reduce --fold 1.6 { |it, acc| $acc * ($it.a | into int) + ($it.b | into int) }
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "14.8");
|
|
}
|
|
|
|
#[test]
|
|
fn reduce_with_return_in_closure() {
|
|
let actual = nu!(pipeline(
|
|
"
|
|
[1, 2] | reduce --fold null { |it, state|
|
|
if $it == 1 {
|
|
return 10
|
|
};
|
|
return ($it * $state)
|
|
}
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "20");
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn reduce_enumerate_example() {
|
|
let actual = nu!(pipeline(
|
|
"
|
|
echo one longest three bar | enumerate
|
|
| reduce { |it, acc| if ($it.item | str length) > ($acc.item | str length) {echo $it} else {echo $acc}}
|
|
| get index
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "1");
|
|
}
|
|
|
|
#[test]
|
|
fn reduce_enumerate_integer_addition_example() {
|
|
let actual = nu!(pipeline(
|
|
"
|
|
echo [1 2 3 4]
|
|
| enumerate
|
|
| reduce { |it, acc| { index: ($it.index) item: ($acc.item + $it.item)} }
|
|
| get item
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "10");
|
|
}
|
|
|
|
#[test]
|
|
fn folding_with_tables() {
|
|
let actual = nu!(pipeline(
|
|
"
|
|
echo [10 20 30 40]
|
|
| reduce --fold [] { |it, acc|
|
|
with-env { value: $it } {
|
|
echo $acc | append (10 * ($env.value | into int))
|
|
}
|
|
}
|
|
| math sum
|
|
"
|
|
));
|
|
|
|
assert_eq!(actual.out, "1000");
|
|
}
|
|
|
|
#[test]
|
|
fn error_reduce_fold_type_mismatch() {
|
|
let actual = nu!(pipeline(
|
|
"echo a b c | reduce --fold 0 { |it, acc| $acc + $it }"
|
|
));
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("nu::shell::operator_incompatible_types"));
|
|
}
|
|
|
|
#[test]
|
|
fn error_reduce_empty() {
|
|
let actual = nu!(pipeline("reduce { |it, acc| $acc + $it }"));
|
|
|
|
assert!(actual.err.contains("no input value was piped in"));
|
|
}
|
|
|
|
#[test]
|
|
fn enumerate_reduce_example() {
|
|
let actual = nu!(pipeline(
|
|
"[one longest three bar] | enumerate | reduce {|it, acc| if ($it.item | str length) > ($acc.item | str length) { $it } else { $acc }} | get index"
|
|
));
|
|
|
|
assert_eq!(actual.out, "1");
|
|
}
|