mirror of
https://github.com/nushell/nushell.git
synced 2024-12-26 17:09:06 +01:00
667502e8da
# Description this PR is an attempt at making the main CI workflow a bit easier to read, understand and work with 🤞 ## changelog - remove the deprecated `nu-coverage` job which was taking place for nothing - remove useless comments, i.e. comments that just say the same thing as the line they comment, e.g. the previous `on.push` comment, and comments that can be explained with a `git blame` inside an IDE, e.g. the comment about removing `--profile ci` on the `cargo install` in the std job - rename `nu-fmt-clippy` and `nu-tests` to `fmt-clippy` and `tests` as we already know we are working with Nushell - rename the "*style*" to "*feature*" which is exactly what `default`, `dataframe` and `extra` are - remove the `strategy.matrix.rust: stable` key: i couldn't find any documentation for this and it's not used in the jobs => by default, the toolchain of `actions-rust-lang/setup-rust-toolchain@v1.5.0` is the stable one (see the [documentation](https://github.com/actions-rust-lang/setup-rust-toolchain#inputs)) - add a top-level `env` block with all the environment variables, e.g. `CLIPPY_OPTIONS`, to have them all in one place hope you'll like that 😇 🙏 # User-Facing Changes # Tests + Formatting this PR should not change the different jobs being run in PRs and on the `main` branch. # After Submitting
156 lines
4.3 KiB
YAML
156 lines
4.3 KiB
YAML
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- main
|
|
|
|
name: continuous-integration
|
|
|
|
env:
|
|
NUSHELL_CARGO_TARGET: ci
|
|
NU_LOG_LEVEL: DEBUG
|
|
CLIPPY_OPTIONS: "-D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err"
|
|
|
|
jobs:
|
|
fmt-clippy:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
# Pinning to Ubuntu 20.04 because building on newer Ubuntu versions causes linux-gnu
|
|
# builds to link against a too-new-for-many-Linux-installs glibc version. Consider
|
|
# revisiting this when 20.04 is closer to EOL (April 2025)
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
feature: [default, dataframe, extra]
|
|
include:
|
|
- feature: default
|
|
flags: ""
|
|
- feature: dataframe
|
|
flags: "--features=dataframe"
|
|
- feature: extra
|
|
flags: "--features=extra"
|
|
exclude:
|
|
- platform: windows-latest
|
|
feature: dataframe
|
|
- platform: macos-latest
|
|
feature: dataframe
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
|
|
with:
|
|
rustflags: ""
|
|
|
|
- name: cargo fmt
|
|
run: cargo fmt --all -- --check
|
|
|
|
- name: Clippy
|
|
run: cargo clippy --workspace ${{ matrix.flags }} --exclude nu_plugin_* -- $CLIPPY_OPTIONS
|
|
|
|
tests:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
feature: [default, dataframe, extra]
|
|
include:
|
|
- feature: default
|
|
flags: ""
|
|
- feature: dataframe
|
|
flags: "--features=dataframe"
|
|
- feature: extra
|
|
flags: "--features=extra"
|
|
exclude:
|
|
- platform: windows-latest
|
|
feature: dataframe
|
|
- platform: macos-latest
|
|
feature: dataframe
|
|
- platform: windows-latest
|
|
feature: extra
|
|
- platform: macos-latest
|
|
feature: extra
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
|
|
with:
|
|
rustflags: ""
|
|
|
|
- name: Tests
|
|
run: cargo test --workspace --profile ci --exclude nu_plugin_* ${{ matrix.flags }}
|
|
|
|
std-lib-and-python-virtualenv:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [ubuntu-20.04, macos-latest, windows-latest]
|
|
py:
|
|
- py
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
|
|
with:
|
|
rustflags: ""
|
|
|
|
- name: Install Nushell
|
|
run: cargo install --path . --locked --no-default-features
|
|
|
|
- name: Standard library tests
|
|
run: nu -c 'use std testing; testing run-tests --path crates/nu-std'
|
|
|
|
- name: Setup Python
|
|
uses: actions/setup-python@v4
|
|
with:
|
|
python-version: "3.10"
|
|
|
|
- run: python -m pip install tox
|
|
|
|
- name: Install virtualenv
|
|
run: git clone https://github.com/pypa/virtualenv.git
|
|
shell: bash
|
|
|
|
- name: Test Nushell in virtualenv
|
|
run: |
|
|
cd virtualenv
|
|
# if we encounter problems with bleeding edge tests pin to the latest tag
|
|
# git checkout $(git describe --tags | cut -d - -f 1)
|
|
# We need to disable failing on coverage levels.
|
|
nu -c "open pyproject.toml | upsert tool.coverage.report.fail_under 1 | save patchproject.toml"
|
|
mv patchproject.toml pyproject.toml
|
|
tox -e ${{ matrix.py }} -- -k nushell
|
|
shell: bash
|
|
|
|
plugins:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
|
|
with:
|
|
rustflags: ""
|
|
|
|
- name: Clippy
|
|
run: cargo clippy --package nu_plugin_* ${{ matrix.flags }} -- $CLIPPY_OPTIONS
|
|
|
|
- name: Tests
|
|
run: cargo test --profile ci --package nu_plugin_*
|