nushell/crates/nu-command
Darren Schroeder 0788fe5e72
fully deprecate str collect (#8680)
# Description

This PR fully deprecates `str collect`. It's been "half-deprecatd" for a
long time. This takes it all the way and disallows the command in favor
of `str join`.

# User-Facing Changes

No more `str collect`

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- crates/nu-utils/standard_library/tests.nu` to run the
tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-31 13:23:22 -05:00
..
assets refactor html module (#5246) 2022-04-20 08:50:14 -05:00
src fully deprecate str collect (#8680) 2023-03-31 13:23:22 -05:00
tests Remove proptests for nuon writing/parsing (#8688) 2023-03-31 17:15:16 +02:00
Cargo.toml Remove proptests for nuon writing/parsing (#8688) 2023-03-31 17:15:16 +02:00
LICENSE Include license text in all crates (#5094) 2022-04-08 10:47:13 +02:00