mirror of
https://github.com/nushell/nushell.git
synced 2025-04-29 23:54:26 +02:00
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> The [nushell/demo](https://github.com/nushell/demo) project successfully demonstrated running Nushell in the browser using WASM. However, the current version of Nushell cannot be easily built for the `wasm32-unknown-unknown` target, the default for `wasm-bindgen`. This PR introduces initial support for the `wasm32-unknown-unknown` target by disabling OS-dependent features such as filesystem access, IO, and platform/system-specific functionality. This separation is achieved using a new `os` feature in the following crates: - `nu-cmd-lang` - `nu-command` - `nu-engine` - `nu-protocol` The `os` feature includes all functionality that interacts with an operating system. It is enabled by default, but can be disabled using `--no-default-features`. All crates that depend on these core crates now use `--no-default-features` to allow compilation for WASM. To demonstrate compatibility, the following script builds all crates expected to work with WASM. Direct user interaction, running external commands, working with plugins, and features requiring `openssl` are out of scope for now due to their complexity or reliance on C libraries, which are difficult to compile and link in a WASM environment. ```nushell [ # compatible crates "nu-cmd-base", "nu-cmd-extra", "nu-cmd-lang", "nu-color-config", "nu-command", "nu-derive-value", "nu-engine", "nu-glob", "nu-json", "nu-parser", "nu-path", "nu-pretty-hex", "nu-protocol", "nu-std", "nu-system", "nu-table", "nu-term-grid", "nu-utils", "nuon" ] | each {cargo build -p $in --target wasm32-unknown-unknown --no-default-features} ``` ## Caveats This PR has a few caveats: 1. **`miette` and `terminal-size` Dependency Issue** `miette` depends on `terminal-size`, which uses `rustix` when the target is not Windows. However, `rustix` requires `std::os::unix`, which is unavailable in WASM. To address this, I opened a [PR](https://github.com/eminence/terminal-size/pull/68) for `terminal-size` to conditionally compile `rustix` only when the target is Unix. For now, the `Cargo.toml` includes patches to: - Use my forked version of `terminal-size`. - ~~Use an unreleased version of `miette` that depends on `terminal-size@0.4`.~~ These patches are temporary and can be removed once the upstream changes are merged and released. 2. **Test Output Adjustments** Due to the slight bump in the `miette` version, one test required adjustments to accommodate minor formatting changes in the error output, such as shifted newlines. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> This shouldn't break anything but allows using some crates for targeting `wasm32-unknown-unknown` to revive the demo page eventually. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` I did not add any extra tests, I just checked that compiling works, also when using the host target but unselecting the `os` feature. # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> ~~Breaking the wasm support can be easily done by adding some `use`s or by adding a new dependency, we should definitely add some CI that also at least builds against wasm to make sure that building for it keep working.~~ I added a job to build wasm. --------- Co-authored-by: Ian Manske <ian.manske@pm.me>
210 lines
5.3 KiB
Rust
210 lines
5.3 KiB
Rust
use std::sync::OnceLock;
|
|
|
|
use nu_engine::command_prelude::*;
|
|
use nu_protocol::engine::StateWorkingSet;
|
|
use shadow_rs::shadow;
|
|
|
|
shadow!(build);
|
|
|
|
#[derive(Clone)]
|
|
pub struct Version;
|
|
|
|
impl Command for Version {
|
|
fn name(&self) -> &str {
|
|
"version"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("version")
|
|
.input_output_types(vec![(Type::Nothing, Type::record())])
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Core)
|
|
}
|
|
|
|
fn description(&self) -> &str {
|
|
"Display Nu version, and its build configuration."
|
|
}
|
|
|
|
fn is_const(&self) -> bool {
|
|
true
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
version(engine_state, call.head)
|
|
}
|
|
|
|
fn run_const(
|
|
&self,
|
|
working_set: &StateWorkingSet,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
version(working_set.permanent(), call.head)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
description: "Display Nu version",
|
|
example: "version",
|
|
result: None,
|
|
}]
|
|
}
|
|
}
|
|
|
|
fn push_non_empty(record: &mut Record, name: &str, value: &str, span: Span) {
|
|
if !value.is_empty() {
|
|
record.push(name, Value::string(value, span))
|
|
}
|
|
}
|
|
|
|
pub fn version(engine_state: &EngineState, span: Span) -> Result<PipelineData, ShellError> {
|
|
// Pre-allocate the arrays in the worst case (17 items):
|
|
// - version
|
|
// - major
|
|
// - minor
|
|
// - patch
|
|
// - pre
|
|
// - branch
|
|
// - commit_hash
|
|
// - build_os
|
|
// - build_target
|
|
// - rust_version
|
|
// - rust_channel
|
|
// - cargo_version
|
|
// - build_time
|
|
// - build_rust_channel
|
|
// - allocator
|
|
// - features
|
|
// - installed_plugins
|
|
let mut record = Record::with_capacity(17);
|
|
|
|
record.push("version", Value::string(env!("CARGO_PKG_VERSION"), span));
|
|
|
|
push_version_numbers(&mut record, span);
|
|
|
|
push_non_empty(&mut record, "pre", build::PKG_VERSION_PRE, span);
|
|
|
|
record.push("branch", Value::string(build::BRANCH, span));
|
|
|
|
if let Some(commit_hash) = option_env!("NU_COMMIT_HASH") {
|
|
record.push("commit_hash", Value::string(commit_hash, span));
|
|
}
|
|
|
|
push_non_empty(&mut record, "build_os", build::BUILD_OS, span);
|
|
push_non_empty(&mut record, "build_target", build::BUILD_TARGET, span);
|
|
push_non_empty(&mut record, "rust_version", build::RUST_VERSION, span);
|
|
push_non_empty(&mut record, "rust_channel", build::RUST_CHANNEL, span);
|
|
push_non_empty(&mut record, "cargo_version", build::CARGO_VERSION, span);
|
|
push_non_empty(&mut record, "build_time", build::BUILD_TIME, span);
|
|
push_non_empty(
|
|
&mut record,
|
|
"build_rust_channel",
|
|
build::BUILD_RUST_CHANNEL,
|
|
span,
|
|
);
|
|
|
|
record.push("allocator", Value::string(global_allocator(), span));
|
|
|
|
record.push(
|
|
"features",
|
|
Value::string(features_enabled().join(", "), span),
|
|
);
|
|
|
|
#[cfg(not(feature = "plugin"))]
|
|
let _ = engine_state;
|
|
|
|
#[cfg(feature = "plugin")]
|
|
{
|
|
// Get a list of plugin names and versions if present
|
|
let installed_plugins = engine_state
|
|
.plugins()
|
|
.iter()
|
|
.map(|x| {
|
|
let name = x.identity().name();
|
|
if let Some(version) = x.metadata().and_then(|m| m.version) {
|
|
format!("{name} {version}")
|
|
} else {
|
|
name.into()
|
|
}
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
record.push(
|
|
"installed_plugins",
|
|
Value::string(installed_plugins.join(", "), span),
|
|
);
|
|
}
|
|
|
|
Ok(Value::record(record, span).into_pipeline_data())
|
|
}
|
|
|
|
/// Add version numbers as integers to the given record
|
|
fn push_version_numbers(record: &mut Record, head: Span) {
|
|
static VERSION_NUMBERS: OnceLock<(u8, u8, u8)> = OnceLock::new();
|
|
|
|
let &(major, minor, patch) = VERSION_NUMBERS.get_or_init(|| {
|
|
(
|
|
build::PKG_VERSION_MAJOR.parse().expect("Always set"),
|
|
build::PKG_VERSION_MINOR.parse().expect("Always set"),
|
|
build::PKG_VERSION_PATCH.parse().expect("Always set"),
|
|
)
|
|
});
|
|
record.push("major", Value::int(major.into(), head));
|
|
record.push("minor", Value::int(minor.into(), head));
|
|
record.push("patch", Value::int(patch.into(), head));
|
|
}
|
|
|
|
fn global_allocator() -> &'static str {
|
|
if cfg!(feature = "mimalloc") {
|
|
"mimalloc"
|
|
} else {
|
|
"standard"
|
|
}
|
|
}
|
|
|
|
fn features_enabled() -> Vec<String> {
|
|
let mut names = vec!["default".to_string()];
|
|
|
|
// NOTE: There should be another way to know features on.
|
|
|
|
#[cfg(feature = "trash-support")]
|
|
{
|
|
names.push("trash".to_string());
|
|
}
|
|
|
|
#[cfg(feature = "sqlite")]
|
|
{
|
|
names.push("sqlite".to_string());
|
|
}
|
|
|
|
#[cfg(feature = "static-link-openssl")]
|
|
{
|
|
names.push("static-link-openssl".to_string());
|
|
}
|
|
|
|
#[cfg(feature = "system-clipboard")]
|
|
{
|
|
names.push("system-clipboard".to_string());
|
|
}
|
|
|
|
names.sort();
|
|
|
|
names
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
#[test]
|
|
fn test_examples() {
|
|
use super::Version;
|
|
use crate::test_examples;
|
|
test_examples(Version {})
|
|
}
|
|
}
|