mirror of
https://github.com/nushell/nushell.git
synced 2025-05-07 11:34:26 +02:00
Continuation of #8229 and #8326 # Description The `ShellError` enum at the moment is kind of messy. Many variants are basic tuple structs where you always have to reference the implementation with its macro invocation to know which field serves which purpose. Furthermore we have both variants that are kind of redundant or either overly broad to be useful for the user to match on or overly specific with few uses. So I set out to start fixing the lacking documentation and naming to make it feasible to critically review the individual usages and fix those. Furthermore we can decide to join or split up variants that don't seem to be fit for purpose. # Call to action **Everyone:** Feel free to add review comments if you spot inconsistent use of `ShellError` variants. # User-Facing Changes (None now, end goal more explicit and consistent error messages) # Tests + Formatting (No additional tests needed so far) # Commits (so far) - Remove `ShellError::FeatureNotEnabled` - Name fields on `SE::ExternalNotSupported` - Name field on `SE::InvalidProbability` - Name fields on `SE::NushellFailed` variants - Remove unused `SE::NushellFailedSpannedHelp` - Name field on `SE::VariableNotFoundAtRuntime` - Name fields on `SE::EnvVarNotFoundAtRuntime` - Name fields on `SE::ModuleNotFoundAtRuntime` - Remove usused `ModuleOrOverlayNotFoundAtRuntime` - Name fields on `SE::OverlayNotFoundAtRuntime` - Name field on `SE::NotFound`
402 lines
15 KiB
Rust
402 lines
15 KiB
Rust
use nu_engine::{find_in_dirs_env, CallExt};
|
|
use nu_parser::{parse, parse_module_block, unescape_unquote_string};
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack, StateWorkingSet};
|
|
use nu_protocol::{
|
|
Category, Example, PipelineData, ShellError, Signature, Span, Spanned, SyntaxShape, Type, Value,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct NuCheck;
|
|
|
|
impl Command for NuCheck {
|
|
fn name(&self) -> &str {
|
|
"nu-check"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("nu-check")
|
|
.input_output_types(vec![(Type::String, Type::Bool),
|
|
(Type::ListStream, Type::Bool),
|
|
(Type::List(Box::new(Type::Any)), Type::Bool)])
|
|
// type is string to avoid automatically canonicalizing the path
|
|
.optional("path", SyntaxShape::String, "File path to parse")
|
|
.switch("as-module", "Parse content as module", Some('m'))
|
|
.switch("debug", "Show error messages", Some('d'))
|
|
.switch("all", "Parse content as script first, returns result if success, otherwise, try with module", Some('a'))
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Validate and parse input content."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["syntax", "parse", "debug"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let path: Option<Spanned<String>> = call.opt(engine_state, stack, 0)?;
|
|
let is_module = call.has_flag("as-module");
|
|
let is_debug = call.has_flag("debug");
|
|
let is_all = call.has_flag("all");
|
|
let config = engine_state.get_config();
|
|
let mut contents = vec![];
|
|
|
|
// DO NOT ever try to merge the working_set in this command
|
|
let mut working_set = StateWorkingSet::new(engine_state);
|
|
|
|
if is_all && is_module {
|
|
return Err(ShellError::GenericError(
|
|
"Detected command flags conflict".to_string(),
|
|
"You cannot have both `--all` and `--as-module` on the same command line, please refer to `nu-check --help` for more details".to_string(),
|
|
Some(call.head),
|
|
None, vec![]));
|
|
}
|
|
|
|
match input {
|
|
PipelineData::Value(Value::String { val, span }, ..) => {
|
|
let contents = Vec::from(val);
|
|
if is_all {
|
|
heuristic_parse(&mut working_set, None, &contents, is_debug, call.head)
|
|
} else if is_module {
|
|
parse_module(&mut working_set, None, &contents, is_debug, span)
|
|
} else {
|
|
parse_script(&mut working_set, None, &contents, is_debug, span)
|
|
}
|
|
}
|
|
PipelineData::ListStream(stream, ..) => {
|
|
let list_stream = stream.into_string("\n", config);
|
|
let contents = Vec::from(list_stream);
|
|
|
|
if is_all {
|
|
heuristic_parse(&mut working_set, None, &contents, is_debug, call.head)
|
|
} else if is_module {
|
|
parse_module(&mut working_set, None, &contents, is_debug, call.head)
|
|
} else {
|
|
parse_script(&mut working_set, None, &contents, is_debug, call.head)
|
|
}
|
|
}
|
|
PipelineData::ExternalStream {
|
|
stdout: Some(stream),
|
|
..
|
|
} => {
|
|
let raw_stream: Vec<_> = stream.stream.collect();
|
|
for r in raw_stream {
|
|
match r {
|
|
Ok(v) => contents.extend(v),
|
|
Err(error) => return Err(error),
|
|
};
|
|
}
|
|
|
|
if is_all {
|
|
heuristic_parse(&mut working_set, None, &contents, is_debug, call.head)
|
|
} else if is_module {
|
|
parse_module(&mut working_set, None, &contents, is_debug, call.head)
|
|
} else {
|
|
parse_script(&mut working_set, None, &contents, is_debug, call.head)
|
|
}
|
|
}
|
|
_ => {
|
|
if let Some(path_str) = path {
|
|
// look up the path as relative to FILE_PWD or inside NU_LIB_DIRS (same process as source-env)
|
|
let path = match find_in_dirs_env(&path_str.item, engine_state, stack) {
|
|
Ok(path) => {
|
|
if let Some(path) = path {
|
|
path
|
|
} else {
|
|
return Err(ShellError::FileNotFound(path_str.span));
|
|
}
|
|
}
|
|
Err(error) => return Err(error),
|
|
};
|
|
|
|
// get the expanded path as a string
|
|
let path_str = path.to_string_lossy().to_string();
|
|
|
|
let ext: Vec<_> = path_str.rsplitn(2, '.').collect();
|
|
if ext[0] != "nu" {
|
|
return Err(ShellError::GenericError(
|
|
"Cannot parse input".to_string(),
|
|
"File extension must be the type of .nu".to_string(),
|
|
Some(call.head),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
|
|
// Change currently parsed directory
|
|
let prev_currently_parsed_cwd = if let Some(parent) = path.parent() {
|
|
let prev = working_set.currently_parsed_cwd.clone();
|
|
|
|
working_set.currently_parsed_cwd = Some(parent.into());
|
|
|
|
prev
|
|
} else {
|
|
working_set.currently_parsed_cwd.clone()
|
|
};
|
|
|
|
let result = if is_all {
|
|
heuristic_parse_file(path_str, &mut working_set, call, is_debug)
|
|
} else if is_module {
|
|
parse_file_module(path_str, &mut working_set, call, is_debug)
|
|
} else {
|
|
parse_file_script(path_str, &mut working_set, call, is_debug)
|
|
};
|
|
|
|
// Restore the currently parsed directory back
|
|
working_set.currently_parsed_cwd = prev_currently_parsed_cwd;
|
|
|
|
result
|
|
} else {
|
|
Err(ShellError::GenericError(
|
|
"Failed to execute command".to_string(),
|
|
"Please run 'nu-check --help' for more details".to_string(),
|
|
Some(call.head),
|
|
None,
|
|
Vec::new(),
|
|
))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Parse a input file as script(Default)",
|
|
example: "nu-check script.nu",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Parse a input file as module",
|
|
example: "nu-check --as-module module.nu",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Parse a input file by showing error message",
|
|
example: "nu-check -d script.nu",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Parse an external stream as script by showing error message",
|
|
example: "open foo.nu | nu-check -d script.nu",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Parse an internal stream as module by showing error message",
|
|
example: "open module.nu | lines | nu-check -d --as-module module.nu",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Parse a string as script",
|
|
example: "$'two(char nl)lines' | nu-check ",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Heuristically parse which begins with script first, if it sees a failure, try module afterwards",
|
|
example: "nu-check -a script.nu",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Heuristically parse by showing error message",
|
|
example: "open foo.nu | lines | nu-check -ad",
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn heuristic_parse(
|
|
working_set: &mut StateWorkingSet,
|
|
filename: Option<&str>,
|
|
contents: &[u8],
|
|
is_debug: bool,
|
|
span: Span,
|
|
) -> Result<PipelineData, ShellError> {
|
|
match parse_script(working_set, filename, contents, is_debug, span) {
|
|
Ok(v) => Ok(v),
|
|
Err(_) => {
|
|
match parse_module(
|
|
working_set,
|
|
filename.map(|f| f.to_string()),
|
|
contents,
|
|
is_debug,
|
|
span,
|
|
) {
|
|
Ok(v) => Ok(v),
|
|
Err(_) => {
|
|
if is_debug {
|
|
Err(ShellError::GenericError(
|
|
"Failed to parse content,tried both script and module".to_string(),
|
|
"syntax error".to_string(),
|
|
Some(span),
|
|
Some("Run `nu-check --help` for more details".to_string()),
|
|
Vec::new(),
|
|
))
|
|
} else {
|
|
Ok(PipelineData::Value(Value::boolean(false, span), None))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn heuristic_parse_file(
|
|
path: String,
|
|
working_set: &mut StateWorkingSet,
|
|
call: &Call,
|
|
is_debug: bool,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let (filename, err) = unescape_unquote_string(path.as_bytes(), call.head);
|
|
if err.is_none() {
|
|
if let Ok(contents) = std::fs::read(&path) {
|
|
match parse_script(
|
|
working_set,
|
|
Some(filename.as_str()),
|
|
&contents,
|
|
is_debug,
|
|
call.head,
|
|
) {
|
|
Ok(v) => Ok(v),
|
|
Err(_) => {
|
|
match parse_module(working_set, Some(filename), &contents, is_debug, call.head)
|
|
{
|
|
Ok(v) => Ok(v),
|
|
Err(_) => {
|
|
if is_debug {
|
|
Err(ShellError::GenericError(
|
|
"Failed to parse content,tried both script and module"
|
|
.to_string(),
|
|
"syntax error".to_string(),
|
|
Some(call.head),
|
|
Some("Run `nu-check --help` for more details".to_string()),
|
|
Vec::new(),
|
|
))
|
|
} else {
|
|
Ok(PipelineData::Value(Value::boolean(false, call.head), None))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
Err(ShellError::IOError("Can not read input".to_string()))
|
|
}
|
|
} else {
|
|
Err(ShellError::NotFound { span: call.head })
|
|
}
|
|
}
|
|
|
|
fn parse_module(
|
|
working_set: &mut StateWorkingSet,
|
|
filename: Option<String>,
|
|
contents: &[u8],
|
|
is_debug: bool,
|
|
span: Span,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let filename = filename.unwrap_or_else(|| "empty".to_string());
|
|
|
|
let start = working_set.next_span_start();
|
|
working_set.add_file(filename.clone(), contents);
|
|
let end = working_set.next_span_start();
|
|
|
|
let new_span = Span::new(start, end);
|
|
let (_, _, _, err) = parse_module_block(working_set, new_span, filename.as_bytes(), &[]);
|
|
|
|
if err.is_some() {
|
|
if is_debug {
|
|
let msg = format!(
|
|
r#"Found : {}"#,
|
|
err.expect("Unable to parse content as module")
|
|
);
|
|
Err(ShellError::GenericError(
|
|
"Failed to parse content".to_string(),
|
|
msg,
|
|
Some(span),
|
|
Some("If the content is intended to be a script, please try to remove `--as-module` flag ".to_string()),
|
|
Vec::new(),
|
|
))
|
|
} else {
|
|
Ok(PipelineData::Value(Value::boolean(false, new_span), None))
|
|
}
|
|
} else {
|
|
Ok(PipelineData::Value(Value::boolean(true, new_span), None))
|
|
}
|
|
}
|
|
|
|
fn parse_script(
|
|
working_set: &mut StateWorkingSet,
|
|
filename: Option<&str>,
|
|
contents: &[u8],
|
|
is_debug: bool,
|
|
span: Span,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let (_, err) = parse(working_set, filename, contents, false, &[]);
|
|
if err.is_some() {
|
|
let msg = format!(r#"Found : {}"#, err.expect("Unable to parse content"));
|
|
if is_debug {
|
|
Err(ShellError::GenericError(
|
|
"Failed to parse content".to_string(),
|
|
msg,
|
|
Some(span),
|
|
Some("If the content is intended to be a module, please consider flag of `--as-module` ".to_string()),
|
|
Vec::new(),
|
|
))
|
|
} else {
|
|
Ok(PipelineData::Value(Value::boolean(false, span), None))
|
|
}
|
|
} else {
|
|
Ok(PipelineData::Value(Value::boolean(true, span), None))
|
|
}
|
|
}
|
|
|
|
fn parse_file_script(
|
|
path: String,
|
|
working_set: &mut StateWorkingSet,
|
|
call: &Call,
|
|
is_debug: bool,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let (filename, err) = unescape_unquote_string(path.as_bytes(), call.head);
|
|
if err.is_none() {
|
|
if let Ok(contents) = std::fs::read(&path) {
|
|
parse_script(
|
|
working_set,
|
|
Some(filename.as_str()),
|
|
&contents,
|
|
is_debug,
|
|
call.head,
|
|
)
|
|
} else {
|
|
Err(ShellError::IOError("Can not read path".to_string()))
|
|
}
|
|
} else {
|
|
Err(ShellError::NotFound { span: call.head })
|
|
}
|
|
}
|
|
|
|
fn parse_file_module(
|
|
path: String,
|
|
working_set: &mut StateWorkingSet,
|
|
call: &Call,
|
|
is_debug: bool,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let (filename, err) = unescape_unquote_string(path.as_bytes(), call.head);
|
|
if err.is_none() {
|
|
if let Ok(contents) = std::fs::read(path) {
|
|
parse_module(working_set, Some(filename), &contents, is_debug, call.head)
|
|
} else {
|
|
Err(ShellError::IOError("Can not read path".to_string()))
|
|
}
|
|
} else {
|
|
Err(ShellError::NotFound { span: call.head })
|
|
}
|
|
}
|