nushell

mirror of https://github.com/nushell/nushell.git synced 2025-05-28 14:07:08 +02:00

History

refactor(parser): use var_id for most constants in ResolvedImportPattern (#14920 )

# Description

This PR replaces most of the constants in `ResolvedImportPattern` from
values to VarIds, this has benefits of:
1. less duplicated variables in state
2. precise span of variable, for example when calling `goto def` on a
const imported by the `use` command, this allows it to find the original
definition, instead of where the `use` command is.

Note that the logic is different here for nested submodules, not all
values are flattened and propagated to the outmost record variable, but
I didn't find any differences in real world usage.

I noticed that it was changed from `VarId` to `Value` in #10049.
Maybe @kubouch can find some edge cases where this PR fails to work as
expected.

In my view, the record constants for `ResolvedImportPattern` should even
reduced to single entry, if not able to get rid of.

# User-Facing Changes

# Tests + Formatting

# After Submitting

2025-01-26 15:43:34 +02:00

src

refactor(parser): use var_id for most constants in ResolvedImportPattern (#14920 )

2025-01-26 15:43:34 +02:00

Cargo.toml

Use nucleo instead of skim for completions (#14846 )

2025-01-17 06:24:00 -06:00

LICENSE

Integrated Language Server (#10723 )

2023-11-02 10:18:57 -05:00

README.md

Add top-level crate documentation/READMEs (#12907 )

2024-07-14 10:10:41 +02:00

README.md

Implementation of the Nushell language server.

See the Language Server Protocol specification

Internal Nushell crate

This crate implements components of Nushell and is not designed to support plugin authors or other users directly.