mirror of
https://github.com/nushell/nushell.git
synced 2025-04-30 08:04:25 +02:00
0788fe5e72
# Description This PR fully deprecates `str collect`. It's been "half-deprecatd" for a long time. This takes it all the way and disallows the command in favor of `str join`. # User-Facing Changes No more `str collect` # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-utils/standard_library/tests.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
29 lines
1.3 KiB
Rust
29 lines
1.3 KiB
Rust
use std::collections::HashMap;
|
|
|
|
/// Return map of <deprecated_command_name, new_command_name>
|
|
/// This covers simple deprecated commands nicely, but it's not great for deprecating
|
|
/// subcommands like `foo bar` where `foo` is still a valid command.
|
|
/// For those, it's currently easiest to have a "stub" command that just returns an error.
|
|
pub fn deprecated_commands() -> HashMap<String, String> {
|
|
HashMap::from([
|
|
("keep".to_string(), "take".to_string()),
|
|
("match".to_string(), "find".to_string()),
|
|
("nth".to_string(), "select".to_string()),
|
|
("pivot".to_string(), "transpose".to_string()),
|
|
("unalias".to_string(), "hide".to_string()),
|
|
("all?".to_string(), "all".to_string()),
|
|
("any?".to_string(), "any".to_string()),
|
|
("empty?".to_string(), "is-empty".to_string()),
|
|
(
|
|
"build-string".to_string(),
|
|
"str join'/'string concatenation with '+'".to_string(),
|
|
),
|
|
("fetch".to_string(), "http get".to_string()),
|
|
("post".to_string(), "http post".to_string()),
|
|
("str lpad".to_string(), "fill".to_string()),
|
|
("str rpad".to_string(), "fill".to_string()),
|
|
("benchmark".to_string(), "timeit".to_string()),
|
|
("str collect".to_string(), "str join".to_string()),
|
|
])
|
|
}
|