Artemiy 1867bb1a88 Fix incorrect handling of boolean flags for builtin commands (#11492) ... # Description Possible fix of #11456 This PR fixes a bug where builtin commands did not respect the logic of dynamically passed boolean flags. The reason is [has_flag](6f59abaf43/crates/nu-protocol/src/ast/call.rs (L204C5-L212C6)) method did not evaluate and take into consideration expression used with flag. To address this issue a solution is proposed: 1. `has_flag` method is moved to `CallExt` and new logic to evaluate expression and check if it is a boolean value is added 2. `has_flag_const` method is added to `CallExt` which is a constant version of `has_flag` 3. `has_named` method is added to `Call` which is basically the old logic of `has_flag` 4. All usages of `has_flag` in code are updated, mostly to pass `engine_state` and `stack` to new `has_flag`. In `run_const` commands it is replaced with `has_flag_const`. And in a few select places: parser, `to nuon` and `into string` old logic via `has_named` is used. # User-Facing Changes Explicit values of boolean flags are now respected in builtin commands. Before:  After:  Another example: Before:  After:  # Tests + Formatting Added test reproducing some variants of original issue.		2024-01-11 17:19:48 +02:00
..
cal.rs	Fix incorrect handling of boolean flags for builtin commands (#11492)	2024-01-11 17:19:48 +02:00
generate.rs	Enforce required, optional, and rest positional arguments start with an uppercase and end with a period. (#11285)	2023-12-15 14:32:37 +08:00
mod.rs	remove the unfold command (#10773)	2023-11-17 06:50:20 +08:00
seq_char.rs	Enforce required, optional, and rest positional arguments start with an uppercase and end with a period. (#11285)	2023-12-15 14:32:37 +08:00
seq_date.rs	Fix incorrect handling of boolean flags for builtin commands (#11492)	2024-01-11 17:19:48 +02:00
seq.rs	Enforce required, optional, and rest positional arguments start with an uppercase and end with a period. (#11285)	2023-12-15 14:32:37 +08:00