mirror of
https://github.com/nushell/nushell.git
synced 2025-01-10 08:18:57 +01:00
b5ff46db6a
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR replaces `ropey` with `lsp-textdocument` for easier utf16 position handling. As a side effect, if fixes the following crashing bug: 1. create a `foo.nu` file with errors in it 2. in `bar.nu`, add code `use foo.nu *` # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> * <s>Diagnostics are now triggered only with document open/save, that's my personal preference. Changing back to previous behavior is easy if you guys have other concerns.</s> * UTF-8 position encoding is not supported by lsp-textdocument, but that's not an issue, since the previous utf-8 ropey implementation is buggy when used in real scenarios in a text editor. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> No new tests added, removed some utf-8 related ones. # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
35 lines
1006 B
TOML
35 lines
1006 B
TOML
[package]
|
|
authors = ["The Nushell Project Developers"]
|
|
description = "Nushell's integrated LSP server"
|
|
repository = "https://github.com/nushell/nushell/tree/main/crates/nu-lsp"
|
|
name = "nu-lsp"
|
|
version = "0.101.1"
|
|
edition = "2021"
|
|
license = "MIT"
|
|
|
|
[dependencies]
|
|
nu-cli = { path = "../nu-cli", version = "0.101.1" }
|
|
nu-parser = { path = "../nu-parser", version = "0.101.1" }
|
|
nu-protocol = { path = "../nu-protocol", version = "0.101.1" }
|
|
|
|
reedline = { workspace = true }
|
|
|
|
crossbeam-channel = { workspace = true }
|
|
lsp-server = { workspace = true }
|
|
lsp-types = { workspace = true }
|
|
lsp-textdocument = { workspace = true }
|
|
miette = { workspace = true }
|
|
serde = { workspace = true }
|
|
serde_json = { workspace = true }
|
|
url = { workspace = true }
|
|
|
|
[dev-dependencies]
|
|
nu-cmd-lang = { path = "../nu-cmd-lang", version = "0.101.1" }
|
|
nu-command = { path = "../nu-command", version = "0.101.1" }
|
|
nu-test-support = { path = "../nu-test-support", version = "0.101.1" }
|
|
|
|
assert-json-diff = "2.0"
|
|
|
|
[lints]
|
|
workspace = true
|