mirror of
https://github.com/nushell/nushell.git
synced 2024-11-23 00:43:33 +01:00
1794ad51bd
* fix #4140 We are passing commands into a shell underneath but we were not escaping arguments correctly. This new version of the code also takes into consideration the ";" and "&" characters, which have special meaning in shells. We would probably benefit from a more robust way to join arguments to shell programs. Python's stdlib has shlex.join, and perhaps we can take that implementation as a reference. * clean up escaping of posix shell args I believe the right place to do escaping of arguments was in the spawn_sh_command function. Note that this change prevents things like: ^echo "$(ls)" from executing the ls command. Instead, this will just print $(ls) The regex has been taken from the python stdlib implementation of shlex.quote * fix non-literal parameters and single quotes * address clippy's comments * fixup! address clippy's comments * test that subshell commands are sanitized properly |
||
---|---|---|
.. | ||
commands | ||
mod.rs |