mirror of
https://github.com/nushell/nushell.git
synced 2024-12-26 17:09:06 +01:00
12effd9b4e
# Description
Slightly refactors the cell path functions (`insert_data_at_cell_path`,
etc.) for `Value` to fix a few bugs and ensure consistent behavior.
Namely, case (in)sensitivity now applies to lazy records just like it
does for regular `Records`. Also, the insert behavior of `insert` and
`upsert` now match, alongside fixing a few related bugs described below.
Otherwise, a few places were changed to use the `Record` API.
# Tests
Added tests for two bugs:
- `{a: {}} | insert a.b.c 0`: before this PR, doesn't create the
innermost record `c`.
- `{table: [[col]; [{a: 1}], [{a: 1}]]} | insert table.col.b 2`: before
this PR, doesn't add the field `b: 2` to each row.
107 lines
2.7 KiB
Rust
107 lines
2.7 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn sets_the_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| upsert dev-dependencies.pretty_assertions "0.7.0"
|
|
| get dev-dependencies.pretty_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn doesnt_convert_record_to_table() {
|
|
let actual = nu!("{a:1} | upsert a 2 | to nuon");
|
|
assert_eq!(actual.out, "{a: 2}");
|
|
}
|
|
|
|
#[test]
|
|
fn sets_the_column_from_a_block_full_stream_output() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{content: null}
|
|
| upsert content {|| open --raw cargo_sample.toml | lines | first 5 }
|
|
| get content.1
|
|
| str contains "nu"
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn sets_the_column_from_a_subexpression() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
{content: null}
|
|
| upsert content (open --raw cargo_sample.toml | lines | first 5)
|
|
| get content.1
|
|
| str contains "nu"
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn upsert_uses_enumerate_index_inserting() {
|
|
let actual = nu!(
|
|
"[[a]; [7] [6]] | enumerate | upsert b {|el| $el.index + 1 + $el.item.a } | flatten | to nuon"
|
|
);
|
|
|
|
assert_eq!(actual.out, "[[index, a, b]; [0, 7, 8], [1, 6, 8]]");
|
|
}
|
|
|
|
#[test]
|
|
fn upsert_uses_enumerate_index_updating() {
|
|
let actual = nu!("[[a]; [7] [6]] | enumerate | upsert a {|el| $el.index + 1 + $el.item.a } | flatten | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[index, a]; [0, 8], [1, 8]]");
|
|
}
|
|
|
|
#[test]
|
|
fn index_does_not_exist() {
|
|
let actual = nu!("[1,2,3] | upsert 4 4");
|
|
|
|
assert!(actual.err.contains("index too large (max: 3)"));
|
|
}
|
|
|
|
#[test]
|
|
fn upsert_empty() {
|
|
let actual = nu!("[] | upsert 1 1");
|
|
|
|
assert!(actual.err.contains("index too large (max: 0)"));
|
|
}
|
|
|
|
#[test]
|
|
fn upsert_support_lazy_record() {
|
|
let actual =
|
|
nu!(r#"let x = (lazy make -c ["h"] -g {|a| $a | str upcase}); $x | upsert h 10 | get h"#);
|
|
assert_eq!(actual.out, "10");
|
|
|
|
let actual =
|
|
nu!(r#"let x = (lazy make -c ["h"] -g {|a| $a | str upcase}); $x | upsert aa 10 | get aa"#);
|
|
assert_eq!(actual.out, "10");
|
|
}
|
|
|
|
#[test]
|
|
fn deep_cell_path_creates_all_nested_records() {
|
|
let actual = nu!(r#"{a: {}} | insert a.b.c 0 | get a.b.c"#);
|
|
assert_eq!(actual.out, "0");
|
|
}
|
|
|
|
#[test]
|
|
fn upserts_all_rows_in_table_in_record() {
|
|
let actual = nu!(
|
|
r#"{table: [[col]; [{a: 1}], [{a: 1}]]} | insert table.col.b 2 | get table.col.b | to nuon"#
|
|
);
|
|
assert_eq!(actual.out, "[2, 2]");
|
|
}
|