nushell/crates/nu-command/src
WindSoilder 191cd2c970
save command: Don't use BufWriter to write external strem to a file (#9377)
# Description
Fixes: #9293

The problem is caused by `save` makes a `BufferWriter` for output file,
when external commands redirect it's output to a file, the content is
bufferred first...

To fix the issue, I'd like to introduce a `--no-buf` flag for `save`
command, and it's only used in redirection scenario.

Sorry it's hard to test against it in test, because it requires external
command to sleep or pause...

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the
standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->

---------

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
2023-06-10 10:07:26 +02:00
..
bytes make bytes at use ranges (#8710) 2023-04-03 04:28:36 +12:00
charting fix: fixed typo and improved Value TypeMismatch exceptions (#8324) 2023-03-22 09:47:40 +01:00
conversions Fix clippy warnings (upcoming) (#9282) 2023-05-25 10:58:18 +12:00
database Add pattern matching (#8590) 2023-03-24 14:52:01 +13:00
date Update some help examples (#8759) 2023-04-05 18:36:00 -05:00
debug Apply nightly clippy fixes (#9381) 2023-06-08 18:49:58 +02:00
deprecated REFACTOR: remove deprecated commands (old-alias) (#9056) 2023-05-04 00:08:07 +02:00
env Add --redirect-combine option to run-external (#8918) 2023-04-28 07:55:48 -05:00
experimental fix is-admin example (#9350) 2023-06-03 15:11:14 -05:00
filesystem save command: Don't use BufWriter to write external strem to a file (#9377) 2023-06-10 10:07:26 +02:00
filters use "search_result" style to colorize matching strings (fixes #9275) (#9326) 2023-06-01 15:51:18 -05:00
formats Avoid blocking when o+e> redirects too much stderr message (#8784) 2023-05-17 17:47:03 -05:00
generators Document and critically review ShellError variants - Ep. 2 (#8326) 2023-03-06 11:31:07 +01:00
hash optimize hash md5 for binary input (#8860) 2023-04-13 19:29:06 +02:00
math Adding more math constants (and a small correction to the description of an existing one) (#9181) 2023-05-31 20:28:08 -05:00
misc REFACTOR: move source out of deprecated commands (#9060) 2023-05-04 00:02:03 +02:00
network add http options command (#9365) 2023-06-09 08:00:40 -05:00
path Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
platform fix padding when running input list on tables (#9316) 2023-05-31 18:31:46 +02:00
random Document and critically review ShellError variants - Ep. 3 (#8340) 2023-03-06 18:33:09 +01:00
shells REFACTOR: remove the shell commands (#8415) 2023-05-13 12:40:11 -05:00
strings Apply nightly clippy fixes (#9381) 2023-06-08 18:49:58 +02:00
system remove unused dependencies (#9230) 2023-05-18 11:37:20 -05:00
viewers Fix config creation during printing (#9353) 2023-06-04 22:04:28 +03:00
default_context.rs add http options command (#9365) 2023-06-09 08:00:40 -05:00
example_test.rs Change group-by to accept cell paths (#9020) 2023-05-17 18:34:44 -05:00
hook.rs Fix config creation during printing (#9353) 2023-06-04 22:04:28 +03:00
input_handler.rs Box ShellError in Value::Error (#8375) 2023-03-12 09:57:27 +01:00
lib.rs nu-cmd-extra crate infrastructure in place with the Bits command as the model for adding other commands (#9327) 2023-06-01 10:46:16 -07:00
progress_bar.rs cp progress bar implementation (#8012) 2023-02-22 11:57:38 -08:00
sort_utils.rs Support passing an empty list to sort, uniq, sort-by, and uniq-by (issue #5957) (#8669) 2023-03-29 19:55:38 -07:00
util.rs Fix process_range on 32-bit platforms (#8842) 2023-04-11 06:52:42 +12:00