mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
1af1e0b5a3
# Description Try to fix #7347, this pr does not fix the error message to `upserting beyond 1 + the list's length doesn't work,`, I feel this is still not explicit or general engouh, if we want to change, what would be the best message to be printed out ? Add tests too # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - [x] `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
110 lines
2.5 KiB
Rust
110 lines
2.5 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn sets_the_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| upsert dev-dependencies.pretty_assertions "0.7.0"
|
|
| get dev-dependencies.pretty_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn doesnt_convert_record_to_table() {
|
|
let actual = nu!(
|
|
cwd: ".", r#"{a:1} | upsert a 2 | to nuon"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "{a: 2}");
|
|
}
|
|
|
|
#[cfg(features = "inc")]
|
|
#[test]
|
|
fn sets_the_column_from_a_block_run_output() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml
|
|
| upsert dev-dependencies.pretty_assertions { open cargo_sample.toml | get dev-dependencies.pretty_assertions | inc --minor }
|
|
| get dev-dependencies.pretty_assertions
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
}
|
|
|
|
#[test]
|
|
fn sets_the_column_from_a_block_full_stream_output() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
wrap content
|
|
| upsert content { open --raw cargo_sample.toml | lines | first 5 }
|
|
| get content.1
|
|
| str contains "nu"
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn sets_the_column_from_a_subexpression() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
wrap content
|
|
| upsert content (open --raw cargo_sample.toml | lines | first 5)
|
|
| get content.1
|
|
| str contains "nu"
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn uses_optional_index_argument_inserting() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a]; [7] [6]] | upsert b {|el ind| $ind + 1 + $el.a } | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[a, b]; [7, 8], [6, 8]]");
|
|
}
|
|
|
|
#[test]
|
|
fn uses_optional_index_argument_updating() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a]; [7] [6]] | upsert a {|el ind| $ind + 1 + $el.a } | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[a]; [8], [8]]");
|
|
}
|
|
|
|
#[test]
|
|
fn index_does_not_exist() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[1,2,3] | upsert 4 4"#
|
|
));
|
|
|
|
assert!(actual.err.contains("index too large (max: 3)"));
|
|
}
|
|
|
|
#[test]
|
|
fn upsert_empty() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[] | upsert 1 1"#
|
|
));
|
|
|
|
assert!(actual.err.contains("index too large (max: 0)"));
|
|
}
|