Ritik Ranjan 1b2079ffdb
[FIX] #15813 passing infinity to random float generate causes error (#15818)
# Description

This pull request addresses an issue#15813 where passing a infinite
value in the random float 1.. command that causes a panic in the shell.
The root cause of this problem lies within the rng library, which is
responsible for generating random numbers.

Before

![image](https://github.com/user-attachments/assets/5416e23d-d5a2-40ed-aa9f-4ff46d0e5583)

# User-Facing Changes
Users where seeing panic error when passed unbounded end into range.

# Tests + Formatting
added `generate_inf`

# After Submitting

![image](https://github.com/user-attachments/assets/8453ffad-ad94-44bf-aec4-8d1090842f32)
No error should be there after 

Edit history
1. Updated `After Submitting` section

---------

Co-authored-by: Ritik Ranjan <e02948@ritik.ranjan@hsc.com>
2025-05-27 19:25:50 +02:00

116 lines
3.2 KiB
Rust

use nu_engine::command_prelude::*;
use nu_protocol::{FloatRange, Range};
use rand::random_range;
use std::ops::Bound;
#[derive(Clone)]
pub struct RandomFloat;
impl Command for RandomFloat {
fn name(&self) -> &str {
"random float"
}
fn signature(&self) -> Signature {
Signature::build("random float")
.input_output_types(vec![(Type::Nothing, Type::Float)])
.allow_variants_without_examples(true)
.optional("range", SyntaxShape::Range, "Range of values.")
.category(Category::Random)
}
fn description(&self) -> &str {
"Generate a random float within a range [min..max]."
}
fn search_terms(&self) -> Vec<&str> {
vec!["generate"]
}
fn run(
&self,
engine_state: &EngineState,
stack: &mut Stack,
call: &Call,
_input: PipelineData,
) -> Result<PipelineData, ShellError> {
float(engine_state, stack, call)
}
fn examples(&self) -> Vec<Example> {
vec![
Example {
description: "Generate a default float value between 0 and 1",
example: "random float",
result: None,
},
Example {
description: "Generate a random float less than or equal to 500",
example: "random float ..500",
result: None,
},
Example {
description: "Generate a random float greater than or equal to 100000",
example: "random float 100000..",
result: None,
},
Example {
description: "Generate a random float between 1.0 and 1.1",
example: "random float 1.0..1.1",
result: None,
},
]
}
}
fn float(
engine_state: &EngineState,
stack: &mut Stack,
call: &Call,
) -> Result<PipelineData, ShellError> {
let span = call.head;
let range: Option<Spanned<Range>> = call.opt(engine_state, stack, 0)?;
match range {
Some(range) => {
let range_span = range.span;
let range = FloatRange::from(range.item);
if range.step() < 0.0 {
return Err(ShellError::InvalidRange {
left_flank: range.start().to_string(),
right_flank: match range.end() {
Bound::Included(end) | Bound::Excluded(end) => end.to_string(),
Bound::Unbounded => "".into(),
},
span: range_span,
});
}
let value = match range.end() {
Bound::Included(end) => random_range(range.start()..=end),
Bound::Excluded(end) => random_range(range.start()..end),
Bound::Unbounded => random_range(range.start()..f64::MAX),
};
Ok(PipelineData::Value(Value::float(value, span), None))
}
None => Ok(PipelineData::Value(
Value::float(random_range(0.0..1.0), span),
None,
)),
}
}
#[cfg(test)]
mod test {
use super::*;
#[test]
fn test_examples() {
use crate::test_examples;
test_examples(RandomFloat {})
}
}