mirror of
https://github.com/nushell/nushell.git
synced 2025-04-11 06:48:31 +02:00
# Description When implementing a `Command`, one must also import all the types present in the function signatures for `Command`. This makes it so that we often import the same set of types in each command implementation file. E.g., something like this: ```rust use nu_protocol::ast::Call; use nu_protocol::engine::{Command, EngineState, Stack}; use nu_protocol::{ record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, PipelineData, ShellError, Signature, Span, Type, Value, }; ``` This PR adds the `nu_engine::command_prelude` module which contains the necessary and commonly used types to implement a `Command`: ```rust // command_prelude.rs pub use crate::CallExt; pub use nu_protocol::{ ast::{Call, CellPath}, engine::{Command, EngineState, Stack}, record, Category, Example, IntoInterruptiblePipelineData, IntoPipelineData, IntoSpanned, PipelineData, Record, ShellError, Signature, Span, Spanned, SyntaxShape, Type, Value, }; ``` This should reduce the boilerplate needed to implement a command and also gives us a place to track the breadth of the `Command` API. I tried to be conservative with what went into the prelude modules, since it might be hard/annoying to remove items from the prelude in the future. Let me know if something should be included or excluded.
141 lines
3.9 KiB
Rust
141 lines
3.9 KiB
Rust
use nu_engine::command_prelude::*;
|
|
|
|
#[derive(Clone)]
|
|
pub struct SeqChar;
|
|
|
|
impl Command for SeqChar {
|
|
fn name(&self) -> &str {
|
|
"seq char"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Print a sequence of ASCII characters."
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("seq char")
|
|
.input_output_types(vec![(Type::Nothing, Type::List(Box::new(Type::String)))])
|
|
.required(
|
|
"start",
|
|
SyntaxShape::String,
|
|
"Start of character sequence (inclusive).",
|
|
)
|
|
.required(
|
|
"end",
|
|
SyntaxShape::String,
|
|
"End of character sequence (inclusive).",
|
|
)
|
|
.category(Category::Generators)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "sequence a to e",
|
|
example: "seq char a e",
|
|
result: Some(Value::list(
|
|
vec![
|
|
Value::test_string('a'),
|
|
Value::test_string('b'),
|
|
Value::test_string('c'),
|
|
Value::test_string('d'),
|
|
Value::test_string('e'),
|
|
],
|
|
Span::test_data(),
|
|
)),
|
|
},
|
|
Example {
|
|
description: "sequence a to e, and put the characters in a pipe-separated string",
|
|
example: "seq char a e | str join '|'",
|
|
// TODO: it would be nice to test this example, but it currently breaks the input/output type tests
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
seq_char(engine_state, stack, call)
|
|
}
|
|
}
|
|
|
|
fn is_single_character(ch: &str) -> bool {
|
|
ch.is_ascii() && ch.len() == 1 && ch.chars().all(char::is_alphabetic)
|
|
}
|
|
|
|
fn seq_char(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let start: Spanned<String> = call.req(engine_state, stack, 0)?;
|
|
let end: Spanned<String> = call.req(engine_state, stack, 1)?;
|
|
|
|
if !is_single_character(&start.item) {
|
|
return Err(ShellError::GenericError {
|
|
error: "seq char only accepts individual ASCII characters as parameters".into(),
|
|
msg: "should be 1 character long".into(),
|
|
span: Some(start.span),
|
|
help: None,
|
|
inner: vec![],
|
|
});
|
|
}
|
|
|
|
if !is_single_character(&end.item) {
|
|
return Err(ShellError::GenericError {
|
|
error: "seq char only accepts individual ASCII characters as parameters".into(),
|
|
msg: "should be 1 character long".into(),
|
|
span: Some(end.span),
|
|
help: None,
|
|
inner: vec![],
|
|
});
|
|
}
|
|
|
|
let start = start
|
|
.item
|
|
.chars()
|
|
.next()
|
|
// expect is ok here, because we just checked the length
|
|
.expect("seq char input must contains 2 inputs");
|
|
|
|
let end = end
|
|
.item
|
|
.chars()
|
|
.next()
|
|
// expect is ok here, because we just checked the length
|
|
.expect("seq char input must contains 2 inputs");
|
|
|
|
let span = call.head;
|
|
run_seq_char(start, end, span)
|
|
}
|
|
|
|
fn run_seq_char(start_ch: char, end_ch: char, span: Span) -> Result<PipelineData, ShellError> {
|
|
let mut result_vec = vec![];
|
|
for current_ch in start_ch as u8..end_ch as u8 + 1 {
|
|
result_vec.push((current_ch as char).to_string())
|
|
}
|
|
|
|
let result = result_vec
|
|
.into_iter()
|
|
.map(|x| Value::string(x, span))
|
|
.collect::<Vec<Value>>();
|
|
Ok(Value::list(result, span).into_pipeline_data())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SeqChar {})
|
|
}
|
|
}
|