mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 16:33:37 +01:00
202dfdaee2
should close https://github.com/nushell/nushell/issues/9965 # Description this PR implements the `todo!()` left in `lines`. # User-Facing Changes ### before ```nushell > open . | lines thread 'main' panicked at 'not yet implemented', crates/nu-command/src/filters/lines.rs:248:35 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` ### after ```nushell > open . | lines Error: nu:🐚:io_error × I/O error help: Is a directory (os error 21) ``` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - ⚫ `toolkit test` - ⚫ `toolkit test stdlib` this PR adds the `lines_on_error` test to make sure this does not happen again 😌 # After Submitting |
||
---|---|---|
.. | ||
commands | ||
format_conversions | ||
main.rs |