mirror of
https://github.com/nushell/nushell.git
synced 2024-12-23 23:49:44 +01:00
e0c0d39ede
# Description As title, this pr is going to deprecate `--ignore-shell-errors` and `--ignore-program-errors`. Because I think these two flags makes `do` command complicate, and it should be easy to use `-i` instead. # User-Facing Changes After the pr, using these two flags will raise deprecated warning. ```nushell > do --ignore-program-errors { ^pwd } Error: × Deprecated option ╭─[entry #2:1:1] 1 │ do --ignore-program-errors { ^pwd } · ─┬ · ╰── `--ignore-program-errors` is deprecated and will be removed in 0.102.0. ╰──── help: Please use the `--ignore-errors(-i)` /home/windsoilder/projects/nushell > do --ignore-shell-errors { ^pwd } Error: × Deprecated option ╭─[entry #3:1:1] 1 │ do --ignore-shell-errors { ^pwd } · ─┬ · ╰── `--ignore-shell-errors` is deprecated and will be removed in 0.102.0. ╰──── help: Please use the `--ignore-errors(-i)` /home/windsoilder/projects/nushell ``` # Tests + Formatting NaN
87 lines
2.4 KiB
Rust
87 lines
2.4 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn capture_errors_works() {
|
|
let actual = nu!("do -c {$env.use}");
|
|
|
|
eprintln!("actual.err: {:?}", actual.err);
|
|
|
|
assert!(actual.err.contains("column_not_found"));
|
|
}
|
|
|
|
// TODO: need to add tests under display_error.exit_code = true
|
|
#[test]
|
|
fn capture_errors_works_for_external() {
|
|
let actual = nu!("do -c {nu --testbin fail}");
|
|
assert!(!actual.status.success());
|
|
assert!(!actual.err.contains("exited with code"));
|
|
}
|
|
|
|
// TODO: need to add tests under display_error.exit_code = true
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_pipeline() {
|
|
let actual = nu!("do -c {nu --testbin fail} | echo `text`");
|
|
assert!(!actual.status.success());
|
|
assert!(!actual.err.contains("exited with code"));
|
|
}
|
|
|
|
// TODO: need to add tests under display_error.exit_code = true
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -c {nu --testbin fail}; echo `text`"#);
|
|
assert!(!actual.status.success());
|
|
assert!(!actual.err.contains("exited with code"));
|
|
}
|
|
|
|
#[test]
|
|
fn do_with_semicolon_break_on_failed_external() {
|
|
let actual = nu!(r#"do { nu --not_exist_flag }; `text`"#);
|
|
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_shell_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -s { open asdfasdf.txt }; "text""#);
|
|
|
|
assert!(actual.err.contains("Deprecated option"));
|
|
assert_eq!(actual.out, "text");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_program_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -p { nu -n -c 'exit 1' }; "text""#);
|
|
|
|
assert!(actual.err.contains("Deprecated option"));
|
|
assert_eq!(actual.out, "text");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_should_work_for_external_command() {
|
|
let actual = nu!(r#"do -i { nu --testbin fail asdf }; echo post"#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "post");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_works_with_list_stream() {
|
|
let actual = nu!(r#"do -i { ["a", null, "b"] | ansi strip }"#);
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn run_closure_with_it_using() {
|
|
let actual = nu!(r#"let x = {let it = 3; $it}; do $x"#);
|
|
assert!(actual.err.is_empty());
|
|
assert_eq!(actual.out, "3");
|
|
}
|
|
|
|
#[test]
|
|
fn waits_for_external() {
|
|
let actual = nu!(r#"do -p { nu -c 'sleep 1sec; print before; exit 1'}; print after"#);
|
|
|
|
assert!(actual.err.contains("Deprecated option"));
|
|
assert_eq!(actual.out, "beforeafter");
|
|
}
|