nushell/crates/nu-cli/src
132ikl f4d9ddd3ad
Fix completions for directories with hidden files (#11921)
# Description
Attempting to complete a directory with hidden files could cause a
variety of issues. When Rust parses the partial path to be completed
into components, it removes the trailing `.` since it interprets this to
mean "the current directory", but in the case of the completer we
actually want to treat the trailling `.` as a literal `.`. This PR fixes
this by adding a `.` back into the Path components if the last character
of the path is a `.` AND the path is longer than 1 character (eg., not
just a ".", since that correctly gets interpreted as Component::CurDir).

Here are some things this fixes:
- Panic when tab completing for hidden files in a directory with hidden
files (ex. `ls test/.`)
- Panic when tab completing a directory with only hidden files (since
the common prefix ends with a `.`, causing the previous issue)
- Mishandling of tab completing hidden files in directory (ex. `ls
~/.<TAB>` lists all files instead of just hidden files)
- Trailing `.` being inexplicably removed when tab completing a
directory without hidden files

While testing for this PR I also noticed there is a similar issue when
completing with `..` (ex. `ls ~/test/..<TAB>`) which is not fixed by
this PR (edit: see #11922).

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
N/A

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
Added a hidden-files-within-directories test to the `file_completions`
test.

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-02-26 12:14:19 -06:00
..
commands Add ConfigDirNotFound error (#11849) 2024-02-26 15:42:20 +08:00
completions Fix completions for directories with hidden files (#11921) 2024-02-26 12:14:19 -06:00
menus Name the Value conversion functions more clearly (#11851) 2024-02-17 18:14:16 +00:00
config_files.rs Fix config creation during printing (#9353) 2023-06-04 22:04:28 +03:00
eval_cmds.rs Add Value::coerce_str (#11885) 2024-02-18 17:47:10 +01:00
eval_file.rs Name the Value conversion functions more clearly (#11851) 2024-02-17 18:14:16 +00:00
lib.rs Bump Reedline for the Menu Refactor (#11658) 2024-01-28 08:26:03 -08:00
nu_highlight.rs Name the Value conversion functions more clearly (#11851) 2024-02-17 18:14:16 +00:00
print.rs Fix incorrect handling of boolean flags for builtin commands (#11492) 2024-01-11 17:19:48 +02:00
prompt_update.rs Only run $env.PROMPT_COMMAND once per prompt (copy of #10986) (#11366) 2023-12-18 09:33:04 -06:00
prompt.rs fix shell integration markers (#11352) 2023-12-16 20:12:34 -06:00
reedline_config.rs Remove some unnecessary static Vecs (#11947) 2024-02-24 20:58:01 +01:00
repl.rs Handling errors instead of killing the REPL (#11953) 2024-02-24 15:26:06 +00:00
syntax_highlight.rs Support redirect stderr and stdout+stderr with a pipe (#11708) 2024-02-09 01:30:46 +08:00
util.rs Deprecate --flag: bool in custom command (#11365) 2023-12-21 10:07:08 +01:00
validation.rs Remove old alias implementation (#8797) 2023-04-07 21:09:38 +03:00