mirror of
https://github.com/nushell/nushell.git
synced 2024-11-23 00:43:33 +01:00
387328fe73
# Description
As title, currently on latest main, nushell confused user if it allows
implicit casting between glob and string:
```nushell
let x = "*.txt"
def glob-test [g: glob] { open $g }
glob-test $x
```
It always expand the glob although `$x` is defined as a string.
This pr implements a solution from @kubouch :
> We could make it really strict and disallow all autocasting between
globs and strings because that's what's causing the "magic" confusion.
Then, modify all builtins that accept globs to accept oneof(glob,
string) and the rules would be that globs always expand and strings
never expand
# User-Facing Changes
After this pr, user needs to use `into glob` to invoke `glob-test`, if
user pass a string variable:
```nushell
let x = "*.txt"
def glob-test [g: glob] { open $g }
glob-test ($x | into glob)
```
Or else nushell will return an error.
```
3 │ glob-test $x
· ─┬
· ╰── can't convert string to glob
```
# Tests + Formatting
Done
# After Submitting
Nan
128 lines
2.6 KiB
Rust
128 lines
2.6 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn mut_variable() {
|
|
let actual = nu!("mut x = 3; $x = $x + 1; $x");
|
|
|
|
assert_eq!(actual.out, "4");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_name_builtin_var() {
|
|
let actual = nu!("mut in = 3");
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("'in' is the name of a builtin Nushell variable"));
|
|
}
|
|
|
|
#[test]
|
|
fn mut_name_builtin_var_with_dollar() {
|
|
let actual = nu!("mut $env = 3");
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("'env' is the name of a builtin Nushell variable"))
|
|
}
|
|
|
|
#[test]
|
|
fn mut_variable_in_loop() {
|
|
let actual = nu!("mut x = 1; for i in 1..10 { $x = $x + $i}; $x");
|
|
|
|
assert_eq!(actual.out, "56");
|
|
}
|
|
|
|
#[test]
|
|
fn capture_of_mutable_var() {
|
|
let actual = nu!("mut x = 123; {|| $x }");
|
|
|
|
assert!(actual.err.contains("capture of mutable variable"));
|
|
}
|
|
|
|
#[test]
|
|
fn mut_add_assign() {
|
|
let actual = nu!("mut y = 3; $y += 2; $y");
|
|
|
|
assert_eq!(actual.out, "5");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_minus_assign() {
|
|
let actual = nu!("mut y = 3; $y -= 2; $y");
|
|
|
|
assert_eq!(actual.out, "1");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_multiply_assign() {
|
|
let actual = nu!("mut y = 3; $y *= 2; $y");
|
|
|
|
assert_eq!(actual.out, "6");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_divide_assign() {
|
|
let actual = nu!("mut y = 8; $y /= 2; $y");
|
|
|
|
assert_eq!(actual.out, "4");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_path_insert() {
|
|
let actual = nu!("mut y = {abc: 123}; $y.abc = 456; $y.abc");
|
|
|
|
assert_eq!(actual.out, "456");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_path_insert_list() {
|
|
let actual = nu!("mut a = [0 1 2]; $a.3 = 3; $a | to nuon");
|
|
|
|
assert_eq!(actual.out, "[0, 1, 2, 3]");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_path_upsert() {
|
|
let actual = nu!("mut a = {b:[{c:1}]}; $a.b.0.d = 11; $a.b.0.d");
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_path_upsert_list() {
|
|
let actual = nu!("mut a = [[[3] 2] 1]; $a.0.0.1 = 0; $a.0.2 = 0; $a.2 = 0; $a | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[[3, 0], 2, 0], 1, 0]");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_path_operator_assign() {
|
|
let actual = nu!("mut a = {b:1}; $a.b += 3; $a.b -= 2; $a.b *= 10; $a.b /= 4; $a.b");
|
|
|
|
assert_eq!(actual.out, "5");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_records_update_properly() {
|
|
let actual = nu!("mut a = {}; $a.b.c = 100; $a.b.c");
|
|
assert_eq!(actual.out, "100");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_value_with_if() {
|
|
let actual = nu!("mut a = 3; $a = if 3 == 3 { 10 }; echo $a");
|
|
assert_eq!(actual.out, "10");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_value_with_match() {
|
|
let actual = nu!("mut a = 3; $a = match 3 { 1 => { 'yes!' }, _ => { 'no!' } }; echo $a");
|
|
assert_eq!(actual.out, "no!");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_glob_type() {
|
|
let actual = nu!("mut x: glob = 'aa'; $x | describe");
|
|
assert_eq!(actual.out, "glob");
|
|
}
|