mirror of
https://github.com/nushell/nushell.git
synced 2024-12-25 16:39:08 +01:00
a4952bc029
I think this _might_ fix the issues we've been seeing with plugin tests.
In a nutshell, the plugin tests run `cargo build` to ensure that plugins
have been built:
f6ca62384e/crates/nu-test-support/src/commands.rs (L6)
This PR adds a mutex to ensure that we're never running `cargo build`
concurrently. It also uses an atomic bool to signal when plugins have
already been built, so we can avoid invoking `cargo build` multiple
times unnecessarily.
I can't be certain yet, but I'm guessing the macOS CI problems we've
been seeing come from plugin tests clobbering each other (something
like: test 1 builds the `foo` plugin, then test2 invokes `cargo build`
again and deletes the `foo` plugin from disk).
62 lines
1.7 KiB
Rust
62 lines
1.7 KiB
Rust
use std::{
|
|
io::Read,
|
|
process::{Command, Stdio},
|
|
sync::{
|
|
atomic::{AtomicBool, Ordering::Relaxed},
|
|
Mutex,
|
|
},
|
|
};
|
|
|
|
static CARGO_BUILD_LOCK: Mutex<()> = Mutex::new(());
|
|
static PLUGINS_BUILT: AtomicBool = AtomicBool::new(false);
|
|
|
|
// This runs `cargo build --package nu_plugin_*` to ensure that all plugins
|
|
// have been built before plugin tests run. We use a lock to avoid multiple
|
|
// simultaneous `cargo build` invocations clobbering each other.
|
|
pub fn ensure_plugins_built() {
|
|
let _guard = CARGO_BUILD_LOCK.lock().expect("could not get mutex lock");
|
|
|
|
if PLUGINS_BUILT.load(Relaxed) {
|
|
return;
|
|
}
|
|
|
|
let cargo_path = env!("CARGO");
|
|
let mut arguments = vec!["build", "--package", "nu_plugin_*", "--quiet"];
|
|
|
|
let profile = std::env::var("NUSHELL_CARGO_TARGET");
|
|
if let Ok(profile) = &profile {
|
|
arguments.push("--profile");
|
|
arguments.push(profile);
|
|
}
|
|
|
|
let mut command = Command::new(cargo_path)
|
|
.args(arguments)
|
|
.stdout(Stdio::piped())
|
|
.stderr(Stdio::piped())
|
|
.spawn()
|
|
.expect("Failed to spawn cargo build command");
|
|
|
|
let stderr = command.stderr.take();
|
|
|
|
let success = command
|
|
.wait()
|
|
.expect("failed to wait cargo build command")
|
|
.success();
|
|
|
|
if let Some(mut stderr) = stderr {
|
|
let mut buffer = String::new();
|
|
stderr
|
|
.read_to_string(&mut buffer)
|
|
.expect("failed to read cargo build stderr");
|
|
if !buffer.is_empty() {
|
|
println!("=== cargo build stderr\n{buffer}");
|
|
}
|
|
}
|
|
|
|
if !success {
|
|
panic!("cargo build failed");
|
|
}
|
|
|
|
PLUGINS_BUILT.store(true, Relaxed);
|
|
}
|