mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 09:53:43 +01:00
ecaed7f0ae
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> - adds a `--signed` flag to `into int` to allow parsing binary values as signed integers, the integer size depends on the length of the binary value # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> - attempting to convert binary values larger than 8 bytes into integers now throws an error, with or without `--signed` # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - wrote 3 tests and 1 example for `into int --signed` usage - added an example for unsigned binary `into int` # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> - will add examples from this PR to `into int` documentation
104 lines
2.7 KiB
Rust
104 lines
2.7 KiB
Rust
use chrono::{DateTime, FixedOffset, NaiveDate, TimeZone};
|
|
use rstest::rstest;
|
|
|
|
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn into_int_filesize() {
|
|
let actual = nu!("echo 1kb | into int | each { |it| $it / 1000 }");
|
|
|
|
assert!(actual.out.contains('1'));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_filesize2() {
|
|
let actual = nu!("echo 1kib | into int | each { |it| $it / 1024 }");
|
|
|
|
assert!(actual.out.contains('1'));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_int() {
|
|
let actual = nu!("echo 1024 | into int | each { |it| $it / 1024 }");
|
|
|
|
assert!(actual.out.contains('1'));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_binary() {
|
|
let actual = nu!("echo 0x[01010101] | into int");
|
|
|
|
assert!(actual.out.contains("16843009"));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_binary_signed() {
|
|
let actual = nu!("echo 0x[f0] | into int --signed");
|
|
|
|
assert!(actual.out.contains("-16"));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_binary_back_and_forth() {
|
|
let actual = nu!("echo 0x[f0] | into int | into binary | to nuon");
|
|
|
|
assert!(actual.out.contains("0x[F000000000000000]"));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_binary_signed_back_and_forth() {
|
|
let actual = nu!("echo 0x[f0] | into int --signed | into binary | to nuon");
|
|
|
|
assert!(actual.out.contains("0x[F0FFFFFFFFFFFFFF]"));
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_binary_empty() {
|
|
let actual = nu!("echo 0x[] | into int");
|
|
|
|
assert!(actual.out.contains('0'))
|
|
}
|
|
|
|
#[test]
|
|
fn into_int_binary_signed_empty() {
|
|
let actual = nu!("echo 0x[] | into int --signed");
|
|
|
|
assert!(actual.out.contains('0'))
|
|
}
|
|
|
|
#[test]
|
|
#[ignore]
|
|
fn into_int_datetime1() {
|
|
let dt = DateTime::parse_from_rfc3339("1983-04-13T12:09:14.123456789+00:00");
|
|
eprintln!("dt debug {:?}", dt);
|
|
assert_eq!(
|
|
dt,
|
|
Ok(FixedOffset::east_opt(0)
|
|
.unwrap()
|
|
.from_local_datetime(
|
|
&NaiveDate::from_ymd_opt(1983, 4, 13)
|
|
.unwrap()
|
|
.and_hms_nano_opt(12, 9, 14, 123456789)
|
|
.unwrap()
|
|
)
|
|
.unwrap())
|
|
);
|
|
|
|
let dt_nano = dt.expect("foo").timestamp_nanos_opt().unwrap_or_default();
|
|
assert_eq!(dt_nano % 1_000_000_000, 123456789);
|
|
}
|
|
|
|
#[rstest]
|
|
#[case("1983-04-13T12:09:14.123456789-05:00", "419101754123456789")] // full precision
|
|
#[case("1983-04-13T12:09:14.456789-05:00", "419101754456789000")] // microsec
|
|
#[case("1983-04-13T12:09:14-05:00", "419101754000000000")] // sec
|
|
#[case("2052-04-13T12:09:14.123456789-05:00", "2596640954123456789")] // future date > 2038 epoch
|
|
#[case("1902-04-13T12:09:14.123456789-05:00", "-2137042245876543211")] // past date < 1970
|
|
fn into_int_datetime(#[case] time_in: &str, #[case] int_out: &str) {
|
|
let actual = nu!(&format!(
|
|
r#""{time_in}" | into datetime --format "%+" | into int"#
|
|
));
|
|
|
|
assert_eq!(int_out, actual.out);
|
|
}
|