.cargo

.githooks

.github

assets

benches

clippy

crates

nu-cli

nu-cmd-base

nu-cmd-extra

nu-cmd-lang

nu-cmd-plugin

nu-color-config

nu-command

src

tests

commands

assignment

base

bytes

at.rs

collect.rs

mod.rs

conversions

database

date

debug

hash_

math

move_

network

path

platform

query

random

skip

str_

take

url

alias.rs

all.rs

any.rs

append.rs

break_.rs

cal.rs

cd.rs

chunk_by.rs

chunks.rs

compact.rs

complete.rs

config_env_default.rs

config_nu_default.rs

continue_.rs

debug_info.rs

def.rs

default.rs

detect_columns.rs

do_.rs

drop.rs

du.rs

each.rs

echo.rs

empty.rs

error_make.rs

every.rs

exec.rs

export_def.rs

fill.rs

filter.rs

find.rs

first.rs

flatten.rs

for_.rs

format.rs

generate.rs

get.rs

glob.rs

griddle.rs

group_by.rs

headers.rs

help.rs

histogram.rs

ignore.rs

insert.rs

inspect.rs

interleave.rs

into_datetime.rs

into_filesize.rs

into_int.rs

job.rs

join.rs

last.rs

length.rs

let_.rs

lines.rs

loop_.rs

ls.rs

match_.rs

merge.rs

merge_deep.rs

mktemp.rs

mod.rs

mut_.rs

nu_check.rs

open.rs

par_each.rs

parse.rs

prepend.rs

print.rs

redirection.rs

reduce.rs

reject.rs

rename.rs

return_.rs

reverse.rs

rm.rs

roll.rs

rotate.rs

run_external.rs

save.rs

select.rs

semicolon.rs

seq.rs

seq_char.rs

seq_date.rs

slice.rs

sort.rs

sort_by.rs

source_env.rs

split_column.rs

split_row.rs

start.rs

stor.rs

table.rs

tee.rs

terminal.rs

to_text.rs

transpose.rs

try_.rs

ucp.rs

ulimit.rs

umkdir.rs

uname.rs

uniq.rs

uniq_by.rs

update.rs

upsert.rs

use_.rs

utouch.rs

where_.rs

which.rs

while_.rs

window.rs

with_env.rs

wrap.rs

zip.rs

format_conversions

main.rs

sort_utils.rs

Cargo.toml

LICENSE

README.md

nu-derive-value

nu-engine

nu-explore

nu-glob

nu-json

nu-lsp

nu-parser

nu-path

nu-plugin

nu-plugin-core

nu-plugin-engine

nu-plugin-protocol

nu-plugin-test-support

nu-pretty-hex

nu-protocol

nu-std

nu-system

nu-table

nu-term-grid

nu-test-support

nu-utils

nu_plugin_custom_values

nu_plugin_example

nu_plugin_formats

nu_plugin_gstat

nu_plugin_inc

nu_plugin_nu_example

nu_plugin_polars

nu_plugin_python

nu_plugin_query

nu_plugin_stress_internals

nuon

README.md

devdocs

docker

scripts

src

tests

wix

.gitattributes

.gitignore

CITATION.cff

CODE_OF_CONDUCT.md

CONTRIBUTING.md

Cargo.lock

Cargo.toml

Cross.toml

LICENSE

README.md

SECURITY.md

rust-toolchain.toml

toolkit.nu

typos.toml

Bahex b55ed69c92 fix range bugs in str substring, str index-of, slice, bytes at (#14863) ...

- fixes #14769

# Description

## Bugs

-   `str substring 0..<0`

When passed a range containing no elements, for non-zero cases `str
substring` behaves correctly:
 
    ```nushell
    ("hello world" | str substring 1..<1) == ""
    # => true
    ```

    but if the range is `0..<0`, it returns the whole string instead

    ```nushell
    "hello world" | str substring 0..<0
    # => hello world
    ```
-   `[0 1 2] | range 0..<0`
    Similar behavior to `str substring`
-   `str index-of`
    - off-by-one on end bounds
    - underflow on negative start bounds
- `bytes at` has inconsistent behavior, works correctly when the size is
known, returns one byte less when it's not known (streaming)
This can be demonstrated by comparing the outputs of following snippets
    ```nushell
    "hello world" | into binary | bytes at ..<5 | decode
    # => hello

"hello world" | into binary | chunks 1 | bytes collect | bytes at ..<5 |
decode
    # => hell
    ```
- `bytes at` panics on decreasing (`5..3`) ranges if the input size is
known. Does not panic with streaming input.

## Changes

- implement `FromValue` for `IntRange`, as it is very common to use
integer ranges as arguments
- `IntRange::absolute_start` can now point one-past-end
- `IntRange::absolute_end` converts relative `Included` bounds to
absolute `Excluded` bounds
- `IntRange::absolute_bounds` is a convenience method that calls the
other `absolute_*` methods and transforms reverse ranges to empty at
`start` (`5..3` => `5..<5`)
- refactored `str substring` tests to allow empty exclusive range tests
- fix the `0..<0` case for `str substring` and `str index-of`
- `IntRange::distance` never returns `Included(0)`

  As a general rule `Included(n) == Excluded(n + 1)`.
  
This makes returning `Included(0)` bug prone as users of the function
will likely rely on this general rule and cause bugs.
- `ByteStream::slice` no longer has an off-by-one on inputs without a
known size. This affected `bytes at`.
- `bytes at` no longer panics on reverse ranges
- `bytes at` is now consistent between streaming and non streaming
inputs.

# User-Facing Changes
There should be no noticeable changes other than the bugfix.

# Tests + Formatting

- 🟢 toolkit fmt
- 🟢 toolkit clippy
- 🟢 toolkit test
- 🟢 toolkit test stdlib

# After Submitting
N/A

2025-01-30 06:50:01 -06:00

..

at.rs

fix range bugs in str substring, str index-of, slice, bytes at (#14863)

2025-01-30 06:50:01 -06:00

collect.rs

Add string/binary type color to ByteStream (#12897)

2024-05-20 00:35:32 +00:00

mod.rs

Implementing ByteStream interuption on infinite stream (#13552)

2025-01-11 13:28:08 -08:00