mirror of
https://github.com/nushell/nushell.git
synced 2025-07-19 23:45:57 +02:00
7ce66a9b77
# Description
Type-check all closure arguments, not just required arguments.
Not doing so looks like an oversight.
# User-Facing Changes
Previously, passing an argument of the wrong type to a closure would
fail if the argument is required, but be accepted (ignoring the type
annotation) if the argument is optional:
```
> do {|x: string| $x} 4
Error: nu:🐚:cant_convert
× Can't convert to string.
╭─[entry #13:1:21]
1 │ do {|x: string| $x} 4
· ┬
· ╰── can't convert int to string
╰────
> do {|x?: string| $x} 4
4
> do {|x?: string| $x} 4 | describe
int
```
It now fails the same way in both cases.
# Tests + Formatting
Added tests, the existing tests still pass.
Please let me know if I added the wrong type of test or added them in
the wrong place (I didn't spot similar tests in the nu-cmd-lang crate,
so I put them next to the most-related existing tests I could find...
# After Submitting
I think this is minor enough it doesn't need a doc update, but please
point me in the right direction if not.
77 lines
2.1 KiB
Rust
77 lines
2.1 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn capture_errors_works() {
|
|
let actual = nu!("do -c {$env.use}");
|
|
|
|
eprintln!("actual.err: {:?}", actual.err);
|
|
|
|
assert!(actual.err.contains("column_not_found"));
|
|
}
|
|
|
|
// TODO: need to add tests under display_error.exit_code = true
|
|
#[test]
|
|
fn capture_errors_works_for_external() {
|
|
let actual = nu!("do -c {nu --testbin fail}");
|
|
assert!(!actual.status.success());
|
|
assert!(!actual.err.contains("exited with code"));
|
|
}
|
|
|
|
// TODO: need to add tests under display_error.exit_code = true
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_pipeline() {
|
|
let actual = nu!("do -c {nu --testbin fail} | echo `text`");
|
|
assert!(!actual.status.success());
|
|
assert!(!actual.err.contains("exited with code"));
|
|
}
|
|
|
|
// TODO: need to add tests under display_error.exit_code = true
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -c {nu --testbin fail}; echo `text`"#);
|
|
assert!(!actual.status.success());
|
|
assert!(!actual.err.contains("exited with code"));
|
|
}
|
|
|
|
#[test]
|
|
fn do_with_semicolon_break_on_failed_external() {
|
|
let actual = nu!(r#"do { nu --not_exist_flag }; `text`"#);
|
|
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_should_work_for_external_command() {
|
|
let actual = nu!(r#"do -i { nu --testbin fail asdf }; echo post"#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "post");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_works_with_list_stream() {
|
|
let actual = nu!(r#"do -i { ["a", null, "b"] | ansi strip }"#);
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn run_closure_with_it_using() {
|
|
let actual = nu!(r#"let x = {let it = 3; $it}; do $x"#);
|
|
assert!(actual.err.is_empty());
|
|
assert_eq!(actual.out, "3");
|
|
}
|
|
|
|
#[test]
|
|
fn required_argument_type_checked() {
|
|
let actual = nu!(r#"do {|x: string| $x} 4"#);
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("nu::shell::cant_convert"));
|
|
}
|
|
|
|
#[test]
|
|
fn optional_argument_type_checked() {
|
|
let actual = nu!(r#"do {|x?: string| $x} 4"#);
|
|
assert_eq!(actual.out, "");
|
|
assert!(actual.err.contains("nu::shell::cant_convert"));
|
|
}
|