mirror of
https://github.com/nushell/nushell.git
synced 2024-11-25 18:03:51 +01:00
387328fe73
# Description
As title, currently on latest main, nushell confused user if it allows
implicit casting between glob and string:
```nushell
let x = "*.txt"
def glob-test [g: glob] { open $g }
glob-test $x
```
It always expand the glob although `$x` is defined as a string.
This pr implements a solution from @kubouch :
> We could make it really strict and disallow all autocasting between
globs and strings because that's what's causing the "magic" confusion.
Then, modify all builtins that accept globs to accept oneof(glob,
string) and the rules would be that globs always expand and strings
never expand
# User-Facing Changes
After this pr, user needs to use `into glob` to invoke `glob-test`, if
user pass a string variable:
```nushell
let x = "*.txt"
def glob-test [g: glob] { open $g }
glob-test ($x | into glob)
```
Or else nushell will return an error.
```
3 │ glob-test $x
· ─┬
· ╰── can't convert string to glob
```
# Tests + Formatting
Done
# After Submitting
Nan
98 lines
2.2 KiB
Rust
98 lines
2.2 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn let_name_builtin_var() {
|
|
let actual = nu!("let in = 3");
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("'in' is the name of a builtin Nushell variable"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_doesnt_mutate() {
|
|
let actual = nu!("let i = 3; $i = 4");
|
|
|
|
assert!(actual.err.contains("immutable"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_takes_pipeline() {
|
|
let actual = nu!(r#"let x = "hello world" | str length; print $x"#);
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_allows_in() {
|
|
let actual =
|
|
nu!(r#"def foo [] { let x = $in | str length; print ($x + 10) }; "hello world" | foo"#);
|
|
|
|
assert_eq!(actual.out, "21");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_takes_pipeline() {
|
|
let actual = nu!(r#"mut x = "hello world" | str length; print $x"#);
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_pipeline_allows_in() {
|
|
let actual =
|
|
nu!(r#"def foo [] { mut x = $in | str length; print ($x + 10) }; "hello world" | foo"#);
|
|
|
|
assert_eq!(actual.out, "21");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_redirects_internals() {
|
|
let actual = nu!(r#"let x = echo 'bar'; $x | str length"#);
|
|
|
|
assert_eq!(actual.out, "3");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_redirects_externals() {
|
|
let actual = nu!(r#"let x = nu --testbin cococo 'bar'; $x | str length"#);
|
|
|
|
assert_eq!(actual.out, "3");
|
|
}
|
|
|
|
#[test]
|
|
fn let_err_pipeline_redirects_externals() {
|
|
let actual = nu!(
|
|
r#"let x = with-env [FOO "foo"] {nu --testbin echo_env_stderr FOO e>| str length}; $x"#
|
|
);
|
|
|
|
// have an extra \n, so length is 4.
|
|
assert_eq!(actual.out, "4");
|
|
}
|
|
|
|
#[test]
|
|
fn let_outerr_pipeline_redirects_externals() {
|
|
let actual = nu!(
|
|
r#"let x = with-env [FOO "foo"] {nu --testbin echo_env_stderr FOO o+e>| str length}; $x"#
|
|
);
|
|
|
|
// have an extra \n, so length is 4.
|
|
assert_eq!(actual.out, "4");
|
|
}
|
|
|
|
#[ignore]
|
|
#[test]
|
|
fn let_with_external_failed() {
|
|
// FIXME: this test hasn't run successfully for a long time. We should
|
|
// bring it back to life at some point.
|
|
let actual = nu!(r#"let x = nu --testbin outcome_err "aa"; echo fail"#);
|
|
|
|
assert!(!actual.out.contains("fail"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_glob_type() {
|
|
let actual = nu!("let x: glob = 'aa'; $x | describe");
|
|
assert_eq!(actual.out, "glob");
|
|
}
|