Nils Feierabend 237a685605 Consider PATH when running command is nuscript in windows (#15486) ... <!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> Fixes #15476 # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Consider PATH when checking for potential_nuscript_in_windows to allow executing scripts which are in PATH without having to full path address them. It previously only checked the current working directory so only relative paths to cwd and full path worked. The current implementation runs this then through cmd.exe /D /C which can run it with assoc and ftype set for nushell scripts. We could instead run it through nu as `std::env::current_exe()` avoiding the cmd call and the need for assoc and ftype (see: 8b25173f02). But ive left the current implementation for this intact to not change implementation details, avoid a bigger change and leave this open for discussion here since im not sure if this has any major implications. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> This would now run every external command through PATH an additional time on windows, so potentially twice. I dont think this has any bigger effect. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->		2025-04-04 06:35:36 -05:00
..
sys	update sysinfo to 0.33.1 (#14982)	2025-02-03 06:33:23 -06:00
complete.rs	Fix try not working with let, etc. (#13885)	2024-09-23 06:44:25 -05:00
exec.rs	Remove required positional arguments from run-external and exec (#14765)	2025-01-16 06:10:28 +08:00
mod.rs	Remove required positional arguments from run-external and exec (#14765)	2025-01-16 06:10:28 +08:00
nu_check.rs	More precise ErrorKind::NotFound errors (#15149)	2025-02-22 11:42:44 -05:00
ps.rs	add more columns to macos ps -l (#15341)	2025-03-20 09:53:19 -05:00
registry_query.rs	Refactor I/O Errors (#14927)	2025-01-28 16:03:31 -06:00
run_external.rs	Consider PATH when running command is nuscript in windows (#15486)	2025-04-04 06:35:36 -05:00
uname.rs	Change the usage misnomer to "description" (#13598)	2024-08-22 12:02:08 +02:00
which_.rs	Add "whereis" and "get-command" to which search terms (#14797)	2025-01-10 17:55:41 -06:00