mirror of https://github.com/nushell/nushell.git synced 2024-11-07 09:04:18 +01:00

History

Ian Manske 399a7c8836 Add and use new `Signals` struct (#13314 ) # Description This PR introduces a new `Signals` struct to replace our adhoc passing around of `ctrlc: Option<Arc<AtomicBool>>`. Doing so has a few benefits: - We can better enforce when/where resetting or triggering an interrupt is allowed. - Consolidates `nu_utils::ctrl_c::was_pressed` and other ad-hoc re-implementations into a single place: `Signals::check`. - This allows us to add other types of signals later if we want. E.g., exiting or suspension. - Similarly, we can more easily change the underlying implementation if we need to in the future. - Places that used to have a `ctrlc` of `None` now use `Signals::empty()`, so we can double check these usages for correctness in the future.	2024-07-07 22:29:01 +00:00
..
benchmarks.rs	Add and use new `Signals` struct (#13314 )	2024-07-07 22:29:01 +00:00
README.md	replace Criterion with Divan (#12000 )	2024-03-01 10:09:21 -08:00

Add and use new Signals struct (#13314 )

# Description
This PR introduces a new `Signals` struct to replace our adhoc passing
around of `ctrlc: Option<Arc<AtomicBool>>`. Doing so has a few benefits:
- We can better enforce when/where resetting or triggering an interrupt
is allowed.
- Consolidates `nu_utils::ctrl_c::was_pressed` and other ad-hoc
re-implementations into a single place: `Signals::check`.
- This allows us to add other types of signals later if we want. E.g.,
exiting or suspension.
- Similarly, we can more easily change the underlying implementation if
we need to in the future.
- Places that used to have a `ctrlc` of `None` now use
`Signals::empty()`, so we can double check these usages for correctness
in the future.

2024-07-07 22:29:01 +00:00

benchmarks.rs Add and use new Signals struct (#13314 ) 2024-07-07 22:29:01 +00:00

README.md replace Criterion with Divan (#12000 ) 2024-03-01 10:09:21 -08:00

README.md

Divan benchmarks

These are benchmarks using Divan, a microbenchmarking tool for Rust.

Run all benchmarks with cargo bench

Or run individual benchmarks like cargo bench -- <regex> e.g. cargo bench -- parse