mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
2bacc29d30
# Description This PR changes some commands that previously accepted row conditions (like `$it > 5`) as parameter to accept closures instead. The reasons are: a) The commands would need to move into parser keywords in the future while they feel more like commands to be implemented in Nushell code as a part of standard library. b) In scripts, it is useful to store the predicate condition in a variable which you can't do with row conditions. c) These commands are not used that often to benefit enough from the shorter row condition syntax # User-Facing Changes The following commands now accept **closure** instead of a **row condition**: - `take until` - `take while` - `skip until` - `skip while` - `any` - `all` This is a part of an effort to move away from shape-directed parsing. Related PR: https://github.com/nushell/nushell/pull/7365 # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
64 lines
1.3 KiB
Rust
64 lines
1.3 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn lines() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml -r
|
|
| lines
|
|
| skip while {|it| $it != "[dependencies]" }
|
|
| skip 1
|
|
| first
|
|
| split column "="
|
|
| get column1.0
|
|
| str trim
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "rustyline");
|
|
}
|
|
|
|
#[test]
|
|
fn lines_proper_buffering() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open lines_test.txt -r
|
|
| lines
|
|
| str length
|
|
| to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[8193,3]");
|
|
}
|
|
|
|
#[test]
|
|
fn lines_multi_value_split() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open sample-simple.json
|
|
| get first second
|
|
| lines
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "6");
|
|
}
|
|
|
|
/// test whether this handles CRLF and LF in the same input
|
|
#[test]
|
|
fn lines_mixed_line_endings() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
"foo\nbar\r\nquux" | lines | length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3");
|
|
}
|