mirror of
https://github.com/nushell/nushell.git
synced 2025-04-17 17:58:18 +02:00
2388e1e80b
# Description This PR is a response to the issues raised in https://github.com/nushell/nushell/pull/7087. It consists of two changes: * `export-env`, when evaluated in `overlay use`, will see the original environment. Previously, it would see the environment from previous overlay activation. * Added a new `--reload` flag that reloads the overlay. Custom definitions will be kept but the original definitions and environment will be reloaded. This enables a pattern when an overlay is supposed to shadow an existing environment variable, such as `PROMPT_COMMAND`, but `overlay use` would keep loading the value from the first activation. You can easily test it by defining a module ``` module prompt { export-env { let-env PROMPT_COMMAND = (date now | into string) } } ``` Calling `overlay use prompt` for the first time changes the prompt to the current time, however, subsequent calls of `overlay use` won't change the time. That's because overlays, once activated, store their state so they can be hidden and restored at later time. To force-reload the environment, use the new flag: Calling `overlay use --reload prompt` repeatedly now updates the prompt with the current time each time. # User-Facing Changes * When calling `overlay use`, if the module has an `export-env` block, the block will see the environment as it is _before_ the overlay is activated. Previously, it was _after_. * A new `overlay use --reload` flag. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. |
||
|---|---|---|
| .. | ||
| overlay | ||
| alias.rs | ||
| ast.rs | ||
| break_.rs | ||
| commandline.rs | ||
| continue_.rs | ||
| debug.rs | ||
| def_env.rs | ||
| def.rs | ||
| describe.rs | ||
| do_.rs | ||
| echo.rs | ||
| error_make.rs | ||
| export_alias.rs | ||
| export_def_env.rs | ||
| export_def.rs | ||
| export_extern.rs | ||
| export_use.rs | ||
| export.rs | ||
| extern_.rs | ||
| for_.rs | ||
| help.rs | ||
| hide_env.rs | ||
| hide.rs | ||
| if_.rs | ||
| ignore.rs | ||
| let_.rs | ||
| loop_.rs | ||
| metadata.rs | ||
| mod.rs | ||
| module.rs | ||
| mut_.rs | ||
| register.rs | ||
| return_.rs | ||
| try_.rs | ||
| use_.rs | ||
| version.rs | ||
| while_.rs | ||