mirror of
https://github.com/nushell/nushell.git
synced 2024-12-26 00:50:03 +01:00
3d008e2c4e
# Description This PR makes it so that non-zero exit codes and termination by signal are treated as a normal `ShellError`. Currently, these are silent errors. That is, if an external command fails, then it's code block is aborted, but the parent block can sometimes continue execution. E.g., see #8569 and this example: ```nushell [1 2] | each { ^false } ``` Before this would give: ``` ╭───┬──╮ │ 0 │ │ │ 1 │ │ ╰───┴──╯ ``` Now, this shows an error: ``` Error: nu:🐚:eval_block_with_input × Eval block failed with pipeline input ╭─[entry #1:1:2] 1 │ [1 2] | each { ^false } · ┬ · ╰── source value ╰──── Error: nu:🐚:non_zero_exit_code × External command had a non-zero exit code ╭─[entry #1:1:17] 1 │ [1 2] | each { ^false } · ──┬── · ╰── exited with code 1 ╰──── ``` This PR fixes #12874, fixes #5960, fixes #10856, and fixes #5347. This PR also partially addresses #10633 and #10624 (only the last command of a pipeline is currently checked). It looks like #8569 is already fixed, but this PR will make sure it is definitely fixed (fixes #8569). # User-Facing Changes - Non-zero exit codes and termination by signal now cause an error to be thrown. - The error record value passed to a `catch` block may now have an `exit_code` column containing the integer exit code if the error was due to an external command. - Adds new config values, `display_errors.exit_code` and `display_errors.termination_signal`, which determine whether an error message should be printed in the respective error cases. For non-interactive sessions, these are set to `true`, and for interactive sessions `display_errors.exit_code` is false (via the default config). # Tests Added a few tests. # After Submitting - Update docs and book. - Future work: - Error if other external commands besides the last in a pipeline exit with a non-zero exit code. Then, deprecate `do -c` since this will be the default behavior everywhere. - Add a better mechanism for exit codes and deprecate `$env.LAST_EXIT_CODE` (it's buggy).
76 lines
1.9 KiB
Rust
76 lines
1.9 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn capture_errors_works() {
|
|
let actual = nu!("do -c {$env.use}");
|
|
|
|
eprintln!("actual.err: {:?}", actual.err);
|
|
|
|
assert!(actual.err.contains("column_not_found"));
|
|
}
|
|
|
|
#[test]
|
|
fn capture_errors_works_for_external() {
|
|
let actual = nu!("do -c {nu --testbin fail}");
|
|
assert!(actual.err.contains("exited with code"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_pipeline() {
|
|
let actual = nu!("do -c {nu --testbin fail} | echo `text`");
|
|
assert!(actual.err.contains("exited with code"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn capture_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -c {nu --testbin fail}; echo `text`"#);
|
|
assert!(actual.err.contains("exited with code"));
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn do_with_semicolon_break_on_failed_external() {
|
|
let actual = nu!(r#"do { nu --not_exist_flag }; `text`"#);
|
|
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_shell_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -s { open asdfasdf.txt }; "text""#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "text");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_program_errors_works_for_external_with_semicolon() {
|
|
let actual = nu!(r#"do -p { nu -n -c 'exit 1' }; "text""#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "text");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_should_work_for_external_command() {
|
|
let actual = nu!(r#"do -i { nu --testbin fail asdf }; echo post"#);
|
|
|
|
assert_eq!(actual.err, "");
|
|
assert_eq!(actual.out, "post");
|
|
}
|
|
|
|
#[test]
|
|
fn ignore_error_works_with_list_stream() {
|
|
let actual = nu!(r#"do -i { ["a", null, "b"] | ansi strip }"#);
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn run_closure_with_it_using() {
|
|
let actual = nu!(r#"let x = {let it = 3; $it}; do $x"#);
|
|
assert!(actual.err.is_empty());
|
|
assert_eq!(actual.out, "3");
|
|
}
|