mirror of
https://github.com/nushell/nushell.git
synced 2024-11-23 00:43:33 +01:00
75180d07de
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
53 lines
1.2 KiB
Rust
53 lines
1.2 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn loop_doesnt_auto_print_in_each_iteration() {
|
|
let actual = nu!("
|
|
mut total = 0;
|
|
loop {
|
|
if $total == 3 {
|
|
break;
|
|
} else {
|
|
$total += 1;
|
|
}
|
|
echo 1
|
|
}");
|
|
// Make sure we don't see any of these values in the output
|
|
// As we do not auto-print loops anymore
|
|
assert!(!actual.out.contains('1'));
|
|
}
|
|
|
|
#[test]
|
|
fn loop_break_on_external_failed() {
|
|
let actual = nu!("
|
|
mut total = 0;
|
|
loop {
|
|
if $total == 3 {
|
|
break;
|
|
} else {
|
|
$total += 1;
|
|
}
|
|
print 1;
|
|
nu --testbin fail;
|
|
}");
|
|
// Note: nu! macro auto replace "\n" and "\r\n" with ""
|
|
// so our output will be `1`.
|
|
assert_eq!(actual.out, "1");
|
|
}
|
|
|
|
#[test]
|
|
fn failed_loop_should_break_running() {
|
|
let actual = nu!("
|
|
mut total = 0;
|
|
loop {
|
|
if $total == 3 {
|
|
break;
|
|
} else {
|
|
$total += 1;
|
|
}
|
|
nu --testbin fail;
|
|
}
|
|
print 3");
|
|
assert!(!actual.out.contains('3'));
|
|
}
|