mirror of
https://github.com/nushell/nushell.git
synced 2024-11-30 04:14:17 +01:00
d95375d494
* Resolve rebase artifacts * Remove leftover dependencies on removed feature * Remove unnecessary 'pub' * Start taking notes and fooling around * Split canonicalize to two versions; Add TODOs One that takes `relative_to` and one that doesn't. More TODO notes. * Merge absolutize to and rename resolve_dots * Add custom absolutize fn and use it in path expand * Convert a couple of dunce::canonicalize to ours * Update nu-path description * Replace all canonicalize with nu-path version * Remove leftover dunce dependencies * Fix broken autocd with trailing slash Trailing slash is preserved *only* in paths that do not contain "." or "..". This should be fixed in the future to cover all paths but for now it at least covers basic cases. * Use dunce::canonicalize for canonicalizing * Alow cd recovery from non-existent cwd * Disable removed canonicalize functionality tests Remove unused import * Break down nu-path into separate modules * Remove unused public imports * Remove abundant cow mapping * Fix clippy warning * Reformulate old canonicalize tests to expand_path They wouldn't work with the new canonicalize. * Canonicalize also ~ and ndots; Unify path joining Also, add doc comments in nu_path::expansions. * Add comment * Avoid expanding ndots if path is not valid UTF-8 With this change, no lossy path->string conversion should happen in the nu-path crate. * Fmt * Slight expand_tilde refactor; Add doc comments * Start nu-path integration tests * Add tests TODO * Fix docstring typo * Fix some doc strings * Add README for nu-path crate * Add a couple of canonicalize tests * Add nu-path integration tests * Add trim trailing slashes tests * Update nu-path dependency * Remove unused import * Regenerate lockfile
46 lines
1.1 KiB
Rust
46 lines
1.1 KiB
Rust
use nu_path::trim_trailing_slash;
|
|
use std::path::MAIN_SEPARATOR;
|
|
|
|
/// Helper function that joins string literals with '/' or '\', based on the host OS
|
|
fn join_path_sep(pieces: &[&str]) -> String {
|
|
let sep_string = String::from(MAIN_SEPARATOR);
|
|
pieces.join(&sep_string)
|
|
}
|
|
|
|
#[test]
|
|
fn trims_trailing_slash_without_trailing_slash() {
|
|
let path = join_path_sep(&["some", "path"]);
|
|
|
|
let actual = trim_trailing_slash(&path);
|
|
|
|
assert_eq!(actual, &path)
|
|
}
|
|
|
|
#[test]
|
|
fn trims_trailing_slash() {
|
|
let path = join_path_sep(&["some", "path", ""]);
|
|
|
|
let actual = trim_trailing_slash(&path);
|
|
let expected = join_path_sep(&["some", "path"]);
|
|
|
|
assert_eq!(actual, &expected)
|
|
}
|
|
|
|
#[test]
|
|
fn trims_many_trailing_slashes() {
|
|
let path = join_path_sep(&["some", "path", "", "", "", ""]);
|
|
|
|
let actual = trim_trailing_slash(&path);
|
|
let expected = join_path_sep(&["some", "path"]);
|
|
|
|
assert_eq!(actual, &expected)
|
|
}
|
|
|
|
#[test]
|
|
fn trims_trailing_slash_empty() {
|
|
let path = String::from(MAIN_SEPARATOR);
|
|
let actual = trim_trailing_slash(&path);
|
|
|
|
assert_eq!(actual, "")
|
|
}
|