mirror of
https://github.com/nushell/nushell.git
synced 2024-12-24 07:59:21 +01:00
f9b5d8bc5e
~~I happened to be reviewing our uses of `thread::spawn()` and came to the conclusion that we're spawning a thread unnecessarily for plugin calls. We were basically doing this:~~ ~~1. Spawn a background thread to send data to the plugin over stdin~~ ~~2. Immediately do a blocking wait for the plugin's response~~ ~~As far as I can tell, there's no point in spawning a thread for 1 (and it may harm error handling) given that we're blocking right away for the response.~~ **Update:** the logic is correct, as confirmed by @WindSoilder [here](https://discord.com/channels/601130461678272522/855947301380947968/1072743414795350037). I've added a comment explaining the thread usage. |
||
|---|---|---|
| .. | ||
| src | ||
| Cargo.toml | ||
| LICENSE | ||