mirror of
https://github.com/nushell/nushell.git
synced 2025-04-04 22:48:41 +02:00
62e56d3581
# Description This PR adds two new `ParseError` and `ShellError` cases for type errors relating to operators. - `OperatorUnsupportedType` is used when a type is not supported by an operator in any way, shape, or form. E.g., `+` does not support `bool`. - `OperatorIncompatibleTypes` is used when a operator is used with types it supports, but the combination of types provided cannot be used together. E.g., `filesize + duration` is not a valid combination. The other preexisting error cases related to operators have been removed and replaced with the new ones above. Namely: - `ShellError::OperatorMismatch` - `ShellError::UnsupportedOperator` - `ParseError::UnsupportedOperationLHS` - `ParseError::UnsupportedOperationRHS` - `ParseError::UnsupportedOperationTernary` # User-Facing Changes - `help operators` now lists the precedence of `not` as 55 instead of 0 (above the other boolean operators). Fixes #13675. - `math median` and `math mode` now ignore NaN values so that `[NaN NaN] | math median` and `[NaN NaN] | math mode` no longer trigger a type error. Instead, it's now an empty input error. Fixing this in earnest can be left for a future PR. - Comparisons with `nan` now return false instead of causing an error. E.g., `1 == nan` is now `false`. - All the operator type errors have been standardized and reworked. In particular, they can now have a help message, which is currently used for types errors relating to `++`. ```nu [1] ++ 2 ``` ``` Error: nu::parser::operator_unsupported_type × The '++' operator does not work on values of type 'int'. ╭─[entry #1:1:5] 1 │ [1] ++ 2 · ─┬ ┬ · │ ╰── int · ╰── does not support 'int' ╰──── help: if you meant to append a value to a list or a record to a table, use the `append` command or wrap the value in a list. For example: `$list ++ $value` should be `$list ++ [$value]` or `$list | append $value`. ```
81 lines
1.3 KiB
Rust
81 lines
1.3 KiB
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn concat_assign_list_int() {
|
|
let actual = nu!(r#"
|
|
mut a = [1 2];
|
|
$a ++= [3 4];
|
|
$a == [1 2 3 4]
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn concat_assign_list_string() {
|
|
let actual = nu!(r#"
|
|
mut a = [a b];
|
|
$a ++= [c d];
|
|
$a == [a b c d]
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn concat_assign_any() {
|
|
let actual = nu!(r#"
|
|
mut a = [1 2 a];
|
|
$a ++= [b 3];
|
|
$a == [1 2 a b 3]
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn concat_assign_both_empty() {
|
|
let actual = nu!(r#"
|
|
mut a = [];
|
|
$a ++= [];
|
|
$a == []
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn concat_assign_string() {
|
|
let actual = nu!(r#"
|
|
mut a = 'hello';
|
|
$a ++= ' world';
|
|
$a == 'hello world'
|
|
"#);
|
|
|
|
assert_eq!(actual.out, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn concat_assign_type_mismatch() {
|
|
let actual = nu!(r#"
|
|
mut a = [];
|
|
$a ++= 'str'
|
|
"#);
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("nu::parser::operator_incompatible_types"));
|
|
}
|
|
|
|
#[test]
|
|
fn concat_assign_runtime_type_mismatch() {
|
|
let actual = nu!(r#"
|
|
mut a = [];
|
|
$a ++= if true { 'str' }
|
|
"#);
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("nu::shell::operator_incompatible_types"));
|
|
}
|