mirror of
https://github.com/nushell/nushell.git
synced 2025-04-09 21:28:55 +02:00
62e56d3581
# Description This PR adds two new `ParseError` and `ShellError` cases for type errors relating to operators. - `OperatorUnsupportedType` is used when a type is not supported by an operator in any way, shape, or form. E.g., `+` does not support `bool`. - `OperatorIncompatibleTypes` is used when a operator is used with types it supports, but the combination of types provided cannot be used together. E.g., `filesize + duration` is not a valid combination. The other preexisting error cases related to operators have been removed and replaced with the new ones above. Namely: - `ShellError::OperatorMismatch` - `ShellError::UnsupportedOperator` - `ParseError::UnsupportedOperationLHS` - `ParseError::UnsupportedOperationRHS` - `ParseError::UnsupportedOperationTernary` # User-Facing Changes - `help operators` now lists the precedence of `not` as 55 instead of 0 (above the other boolean operators). Fixes #13675. - `math median` and `math mode` now ignore NaN values so that `[NaN NaN] | math median` and `[NaN NaN] | math mode` no longer trigger a type error. Instead, it's now an empty input error. Fixing this in earnest can be left for a future PR. - Comparisons with `nan` now return false instead of causing an error. E.g., `1 == nan` is now `false`. - All the operator type errors have been standardized and reworked. In particular, they can now have a help message, which is currently used for types errors relating to `++`. ```nu [1] ++ 2 ``` ``` Error: nu::parser::operator_unsupported_type × The '++' operator does not work on values of type 'int'. ╭─[entry #1:1:5] 1 │ [1] ++ 2 · ─┬ ┬ · │ ╰── int · ╰── does not support 'int' ╰──── help: if you meant to append a value to a list or a record to a table, use the `append` command or wrap the value in a list. For example: `$list ++ $value` should be `$list ++ [$value]` or `$list | append $value`. ```
83 lines
1.7 KiB
Rust
83 lines
1.7 KiB
Rust
use crate::repl::tests::{fail_test, run_test, TestResult};
|
|
|
|
#[test]
|
|
fn contains() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ bar"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn contains_case_insensitive() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ '(?i)BaR'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_contains() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ asdf"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn match_full_line() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ '^foobarbaz$'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_match_full_line() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ '^foobarbaz$'"#, "false")
|
|
}
|
|
|
|
#[test]
|
|
fn starts_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ '^foo'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_starts_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ '^foo'"#, "false")
|
|
}
|
|
|
|
#[test]
|
|
fn ends_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' =~ 'baz$'"#, "true")
|
|
}
|
|
|
|
#[test]
|
|
fn not_ends_with() -> TestResult {
|
|
run_test(r#"'foobarbaz' !~ 'baz$'"#, "false")
|
|
}
|
|
|
|
#[test]
|
|
fn where_works() -> TestResult {
|
|
run_test(
|
|
r#"[{name: somefile.txt} {name: anotherfile.csv }] | where name =~ ^s | get name.0"#,
|
|
"somefile.txt",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn where_not_works() -> TestResult {
|
|
run_test(
|
|
r#"[{name: somefile.txt} {name: anotherfile.csv }] | where name !~ ^s | get name.0"#,
|
|
"anotherfile.csv",
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_regex_fails() -> TestResult {
|
|
fail_test(r#"'foo' =~ '['"#, "Invalid character class")
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_not_regex_fails() -> TestResult {
|
|
fail_test(r#"'foo' !~ '['"#, "Invalid character class")
|
|
}
|
|
|
|
#[test]
|
|
fn regex_on_int_fails() -> TestResult {
|
|
fail_test(r#"33 =~ foo"#, "nu::parser::operator_unsupported_type")
|
|
}
|
|
|
|
#[test]
|
|
fn not_regex_on_int_fails() -> TestResult {
|
|
fail_test(r#"33 !~ foo"#, "nu::parser::operator_unsupported_type")
|
|
}
|