João Fidalgo 63335e99ae Fix usage of --tabs flag while converting to json (#12115) (#12251) ... closes #12115 # Description This fix addresses a bug where the --tabs flag couldn't be utilized due to improper handling of the tab quantity provided by the user. Previously, the code mistakenly attempted to convert the tab quantity to a boolean value, leading to a conversion error. The resolution involves adjusting the condition clauses to properly validate the presence of the flag's value. Now, the code checks whether the get_flag() function returns a value or None associated with the --tabs flag. This adjustment enables the --tabs flag to function correctly, triggering the appropriate condition and allowing the conversion to proceed as expected. Similarly, the fix applies to the --indent flag. Additionally, a default case was added, and the conversion now works properly without flags. Two tests were added to validate the corrected behavior of these flags. # User-Facing Changes Now the conversion should work properly instead of displaying an error. # Tests + Formatting -🟢 toolkit fmt -🟢 toolkit clippy -🟢 toolkit test -🟢 toolkit test stdlib To run added tests: - cargo test --package nu-command --test main -- format_conversions::json::test_tabs_indent_flag - cargo test --package nu-command --test main -- format_conversions::json::test_indent_flag		2024-03-20 11:55:51 -05:00
..
commands	Adjust permissions using umask in mkdir (#12207)	2024-03-14 16:43:42 -05:00
format_conversions	Fix usage of --tabs flag while converting to json (#12115) (#12251)	2024-03-20 11:55:51 -05:00
main.rs	Enforce required, optional, and rest positional arguments start with an uppercase and end with a period. (#11285)	2023-12-15 14:32:37 +08:00