mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 08:23:24 +01:00
2c379cba71
# Description This feature tried to connect reedline with the system clipboard for three special bindings. To do so it uses the `arboard` crate with heavy dependencies for the system X or Wayland server or the Windows APIs. We had issues in the headless CI with it and builds with musl seem to stall. Removing it from the default build should negatively impact only a small subset of users aware of the extra bindings. You can still use the internal clipboard for binding based selection and the terminals extra bindings to copy arbitrary content into the system clipboard. For all other users it removes potential sources of failure and a whole 1 MB of release mode binary size (> 2% reduction). Furthermore a potentially substantial attack surface for Nushell is gone for default builds. - Should resolve #13019 - Work in the spirit of #13603 # User-Facing Changes The `edit` entries `copyselectionsystem`/`copyselectionsystem`/`pastesystem` for keybindings are gone in the default build If you strictly depend on this behavior, you can still build with the addition of `--features system-clipboard`
165 lines
4.7 KiB
YAML
165 lines
4.7 KiB
YAML
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- main
|
|
|
|
name: continuous-integration
|
|
|
|
env:
|
|
NUSHELL_CARGO_PROFILE: ci
|
|
NU_LOG_LEVEL: DEBUG
|
|
# If changing these settings also change toolkit.nu
|
|
CLIPPY_OPTIONS: "-D warnings -D clippy::unwrap_used -D clippy::unchecked_duration_subtraction"
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
fmt-clippy:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
# Pinning to Ubuntu 20.04 because building on newer Ubuntu versions causes linux-gnu
|
|
# builds to link against a too-new-for-many-Linux-installs glibc version. Consider
|
|
# revisiting this when 20.04 is closer to EOL (April 2025)
|
|
#
|
|
# Using macOS 13 runner because 14 is based on the M1 and has half as much RAM (7 GB,
|
|
# instead of 14 GB) which is too little for us right now. Revisit when `dfr` commands are
|
|
# removed and we're only building the `polars` plugin instead
|
|
platform: [windows-latest, macos-13, ubuntu-20.04]
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4.1.7
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
|
|
|
|
- name: cargo fmt
|
|
run: cargo fmt --all -- --check
|
|
|
|
# If changing these settings also change toolkit.nu
|
|
- name: Clippy
|
|
run: cargo clippy --workspace --exclude nu_plugin_* -- $CLIPPY_OPTIONS
|
|
|
|
# In tests we don't have to deny unwrap
|
|
- name: Clippy of tests
|
|
run: cargo clippy --tests --workspace --exclude nu_plugin_* -- -D warnings
|
|
|
|
- name: Clippy of benchmarks
|
|
run: cargo clippy --benches --workspace --exclude nu_plugin_* -- -D warnings
|
|
|
|
tests:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4.1.7
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
|
|
|
|
- name: Tests
|
|
run: cargo test --workspace --profile ci --exclude nu_plugin_*
|
|
- name: Check for clean repo
|
|
shell: bash
|
|
run: |
|
|
if [ -n "$(git status --porcelain)" ]; then
|
|
echo "there are changes";
|
|
git status --porcelain
|
|
exit 1
|
|
else
|
|
echo "no changes in working directory";
|
|
fi
|
|
|
|
std-lib-and-python-virtualenv:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [ubuntu-20.04, macos-latest, windows-latest]
|
|
py:
|
|
- py
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4.1.7
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
|
|
|
|
- name: Install Nushell
|
|
run: cargo install --path . --locked --no-default-features
|
|
|
|
- name: Standard library tests
|
|
run: nu -c 'use crates/nu-std/testing.nu; testing run-tests --path crates/nu-std'
|
|
|
|
- name: Ensure that Cargo.toml MSRV and rust-toolchain.toml use the same version
|
|
run: nu .github/workflows/check-msrv.nu
|
|
|
|
- name: Setup Python
|
|
uses: actions/setup-python@v5
|
|
with:
|
|
python-version: "3.10"
|
|
|
|
- name: Install virtualenv
|
|
run: pip install virtualenv
|
|
shell: bash
|
|
|
|
- name: Test Nushell in virtualenv
|
|
run: nu scripts/test_virtualenv.nu
|
|
shell: bash
|
|
|
|
- name: Check for clean repo
|
|
shell: bash
|
|
run: |
|
|
if [ -n "$(git status --porcelain)" ]; then
|
|
echo "there are changes";
|
|
git status --porcelain
|
|
exit 1
|
|
else
|
|
echo "no changes in working directory";
|
|
fi
|
|
|
|
plugins:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
# Using macOS 13 runner because 14 is based on the M1 and has half as much RAM (7 GB,
|
|
# instead of 14 GB) which is too little for us right now.
|
|
#
|
|
# Failure occurring with clippy for rust 1.77.2
|
|
platform: [windows-latest, macos-13, ubuntu-20.04]
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4.1.7
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
|
|
|
|
- name: Clippy
|
|
run: cargo clippy --package nu_plugin_* -- $CLIPPY_OPTIONS
|
|
|
|
- name: Tests
|
|
run: cargo test --profile ci --package nu_plugin_*
|
|
|
|
- name: Check for clean repo
|
|
shell: bash
|
|
run: |
|
|
if [ -n "$(git status --porcelain)" ]; then
|
|
echo "there are changes";
|
|
git status --porcelain
|
|
exit 1
|
|
else
|
|
echo "no changes in working directory";
|
|
fi
|