mirror of
https://github.com/nushell/nushell.git
synced 2025-01-07 14:59:36 +01:00
af72a18785
# Description In the plugin protocol, I had used `#[serde(untagged)]` on the `Stream` variant to make it smaller and include all of the stream messages at the top level, but unfortunately this causes serde to make really unhelpful errors if anything fails to decode anywhere: ``` Error: nu:🐚:plugin_failed_to_decode × Plugin failed to decode: data did not match any variant of untagged enum PluginOutput ``` If you are trying to develop something using the plugin protocol directly, this error is incredibly unhelpful. Even as a user, this basically just says 'something is wrong'. With this change, the errors are much better: ``` Error: nu:🐚:plugin_failed_to_decode × Plugin failed to decode: unknown variant `PipelineDatra`, expected one of `Error`, `Signature`, `Ordering`, `PipelineData` at line 2 column 37 ``` The only downside is it means I have to duplicate all of the `StreamMessage` variants manually, but there's only 4 of them and they're small. This doesn't actually change the protocol at all - everything is still identical on the wire. # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` |
||
|---|---|---|
| .. | ||
| plugin | ||
| protocol | ||
| serializers | ||
| util | ||
| lib.rs | ||
| sequence.rs | ||