.cargo

.github

assets

benches

crates

nu-cli

nu-cmd-lang

nu-color-config

nu-command

assets

proptest-regressions

src

tests

commands

assignment

bytes

mod.rs

starts_with.rs

date

hash_

math

move_

network

path

platform

query

random

skip

str_

take

url

alias.rs

all.rs

any.rs

append.rs

break_.rs

cal.rs

cd.rs

compact.rs

continue_.rs

cp.rs

def.rs

default.rs

do_.rs

drop.rs

each.rs

echo.rs

empty.rs

enter.rs

error_make.rs

every.rs

exec.rs

export_def.rs

fill.rs

find.rs

first.rs

flatten.rs

for_.rs

format.rs

g.rs

get.rs

glob.rs

group_by.rs

headers.rs

help.rs

histogram.rs

insert.rs

into_filesize.rs

into_int.rs

last.rs

length.rs

let_.rs

lines.rs

loop_.rs

ls.rs

merge.rs

mkdir.rs

mod.rs

mut_.rs

n.rs

nu_check.rs

open.rs

p.rs

parse.rs

prepend.rs

print.rs

range.rs

redirection.rs

reduce.rs

reject.rs

rename.rs

return_.rs

reverse.rs

rm.rs

roll.rs

rotate.rs

run_external.rs

save.rs

select.rs

semicolon.rs

seq.rs

seq_char.rs

shells.rs

sort.rs

sort_by.rs

source_env.rs

split_by.rs

split_column.rs

split_row.rs

table.rs

to_text.rs

touch.rs

transpose.rs

try_.rs

uniq.rs

uniq_by.rs

update.rs

upsert.rs

use_.rs

where_.rs

which.rs

while_.rs

with_env.rs

wrap.rs

zip.rs

format_conversions

main.rs

Cargo.toml

LICENSE

nu-engine

nu-explore

nu-glob

nu-json

nu-parser

nu-path

nu-plugin

nu-pretty-hex

nu-protocol

nu-system

nu-table

nu-term-grid

nu-test-support

nu-utils

nu_plugin_custom_values

nu_plugin_example

nu_plugin_formats

nu_plugin_gstat

nu_plugin_inc

nu_plugin_python

nu_plugin_query

README.md

docker

docs

images

pkg_mgrs

src

tests

wix

.gitignore

.typos.toml

CODE_OF_CONDUCT.md

CONTRIBUTING.md

Cargo.lock

Cargo.toml

Cross.toml

LICENSE

README.md

README.release.txt

build-all-maclin.sh

build-all-windows.cmd

build-all.nu

build.rs

codecov.yml

coverage-local.nu

coverage-local.sh

install-all.ps1

install-all.sh

register-plugins.nu

rust-toolchain.toml

uninstall-all.sh

Doru c602b5a1e8 special-case ExternalStream in bytes starts-with (#8203) ...

# Description
`bytes starts-with` converts the input into a `Value` before running
.starts_with to find if the binary matches. This has two side effects:
it makes the code simpler, only dealing in whole values, and simplifying
a lot of input pipeline handling and value transforming it would
otherwise have to do. _Especially_ in the presence of a cell path to
drill into. It also makes buffers the entire input into memory, which
can take up a lot of memory when dealing with large files, especially if
you only want to check the first few bytes (like for a magic number).

This PR adds a special branch on PipelineData::ExternalStream with a
streaming version of starts_with.

# User-Facing Changes
Opening large files and running bytes starts-with on them will not take
a long time.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# Drawbacks
Streaming checking is more complicated, and there may be bugs. I tested
it with multiple chunks with string data and binary data and it seems to
work alright up to 8k and over bytes, though.

The existing `operate` method still exists because the way it handles
cell paths and values is complicated. This causes some "code
duplication", or at least some intent duplication, between the value
code and the streaming code. This might be worthwhile considering the
performance gains (approaching infinity on larger inputs).

Another thing to consider is that my ExternalStream branch considers
string data as valid input. The operate branch only parses Binary
values, so it would fail. `open` is kind of unpredictable on whether it
returns string data or binary data, even when passing `--raw`. I think
this can be a problem but not really one I'm trying to tackle in this
PR, so, it's worth considering.

2023-02-26 15:17:44 +01:00

..

mod.rs

special-case ExternalStream in bytes starts-with (#8203)

2023-02-26 15:17:44 +01:00

starts_with.rs

special-case ExternalStream in bytes starts-with (#8203)

2023-02-26 15:17:44 +01:00