nushell/crates/nu-plugin-engine/src
Ian Manske 62e56d3581
Rework operator type errors (#14429)
# Description

This PR adds two new `ParseError` and `ShellError` cases for type errors
relating to operators.
- `OperatorUnsupportedType` is used when a type is not supported by an
operator in any way, shape, or form. E.g., `+` does not support `bool`.
- `OperatorIncompatibleTypes` is used when a operator is used with types
it supports, but the combination of types provided cannot be used
together. E.g., `filesize + duration` is not a valid combination.

The other preexisting error cases related to operators have been removed
and replaced with the new ones above. Namely:

- `ShellError::OperatorMismatch`
- `ShellError::UnsupportedOperator`
- `ParseError::UnsupportedOperationLHS`
- `ParseError::UnsupportedOperationRHS`
- `ParseError::UnsupportedOperationTernary`

# User-Facing Changes

- `help operators` now lists the precedence of `not` as 55 instead of 0
(above the other boolean operators). Fixes #13675.
- `math median` and `math mode` now ignore NaN values so that `[NaN NaN]
| math median` and `[NaN NaN] | math mode` no longer trigger a type
error. Instead, it's now an empty input error. Fixing this in earnest
can be left for a future PR.
- Comparisons with `nan` now return false instead of causing an error.
E.g., `1 == nan` is now `false`.
- All the operator type errors have been standardized and reworked. In
particular, they can now have a help message, which is currently used
for types errors relating to `++`.

```nu
[1] ++ 2
```
```
Error: nu::parser::operator_unsupported_type

  × The '++' operator does not work on values of type 'int'.
   ╭─[entry #1:1:5]
 1 │ [1] ++ 2
   ·     ─┬ ┬
   ·      │ ╰── int
   ·      ╰── does not support 'int'
   ╰────
  help: if you meant to append a value to a list or a record to a table, use the `append` command or wrap the value in a list. For example: `$list ++ $value` should be
        `$list ++ [$value]` or `$list | append $value`.
```
2025-02-12 20:03:40 -08:00
..
interface Rework operator type errors (#14429) 2025-02-12 20:03:40 -08:00
plugin_custom_value_with_source Replace raw usize IDs with new types (#13832) 2024-09-30 13:20:15 +02:00
util fix: clippy warnings with --all-features (#15035) 2025-02-07 12:30:25 +01:00
context.rs fix: clippy warnings with --all-features (#15035) 2025-02-07 12:30:25 +01:00
declaration.rs Change the usage misnomer to "description" (#13598) 2024-08-22 12:02:08 +02:00
gc.rs Setup global cargo lint configuration (#13691) 2024-08-28 23:37:17 +02:00
init.rs Error on non-zero exit statuses (#13515) 2024-09-07 06:44:26 +00:00
lib.rs Split the plugin crate (#12563) 2024-04-27 12:08:12 -05:00
persistent.rs Replaced IoError::new_with_additional_context calls that still had Span::unknown() (#15056) 2025-02-08 09:23:28 -06:00
process.rs doc: fix broken doc links (#13644) 2024-08-23 21:17:44 +02:00
source.rs doc: fix broken doc links (#13644) 2024-08-23 21:17:44 +02:00
test_util.rs Split the plugin crate (#12563) 2024-04-27 12:08:12 -05:00