mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 00:13:21 +01:00
6edf91dcae
# Description
Nushell parser now reject comparison operator with 2 strings (e.g.
`"abc" < "cba"`). This pr fixes it.
## before
```nu
~
❯ "abc" < "bca"
Error: nu::parser::unsupported_operation
× less-than comparison is not supported on values of type string
╭─[entry #43:1:1]
1 │ "abc" < "bca"
· ──┬── ┬
· │ ╰── doesn't support this value
· ╰── string
╰────
~
❯ def foo []: nothing -> string { "abc" }
~
❯ (foo) < "bca"
Error: nu::parser::unsupported_operation
× less-than comparison is not supported on values of type string
╭─[entry #53:1:1]
1 │ (foo) < "bca"
· ──┬── ┬
· │ ╰── doesn't support this value
· ╰── string
╰────
```
## after
```nu
~
❯ "abc" < "bca"
true
~
❯ def foo []: nothing -> string { "abc" }
~
❯ (foo) < "bca"
true
```
# User-Facing Changes
Following pattern will be allowed.
| operator | type of lhs | type of rhs | result |
| -------- | ----------- | ----------- | ------ |
| `<` | string | string | bool |
| `<=` | string | string | bool |
| `>` | string | string | bool |
| `>=` | string | string | bool |
# Tests + Formatting
- [x] `cargo fmt --all -- --check` to check standard code formatting
(`cargo fmt --all` applies these changes)
- [x] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used`
to check that you're using the standard code style
- [x] `cargo test --workspace` to check that all tests pass (on Windows
make sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- [x] `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library
# After Submitting
|
||
|---|---|---|
| .. | ||
| test_lex.rs | ||
| test_parser_unicode_escapes.rs | ||
| test_parser.rs | ||