mirror of
https://github.com/nushell/nushell.git
synced 2024-10-17 07:42:53 +02:00
6fc5244439
# Description Prevent a situation where a `def` can't be run due to a poor choice of name. Related: #6335. Hashtags, numbers and filesizes are no longer allowed. `alias` check has been moved because previously `alias 123` would be caught but `alias "123"` would be permitted. # User-Facing Changes Some definitions can no longer be made, but because they couldn't be run previously anyway, it doesn't really matter. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
87 lines
1.9 KiB
Rust
87 lines
1.9 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn alias_simple() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
alias bar = use sample_def.nu greet;
|
|
bar;
|
|
greet
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "hello");
|
|
}
|
|
|
|
#[test]
|
|
fn alias_hiding_1() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
overlay use ./activate-foo.nu;
|
|
$nu.scope.aliases | find deactivate-foo | length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "1");
|
|
}
|
|
|
|
#[test]
|
|
fn alias_hiding_2() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
overlay use ./activate-foo.nu;
|
|
deactivate-foo;
|
|
$nu.scope.aliases | find deactivate-foo | length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0");
|
|
}
|
|
|
|
#[test]
|
|
fn alias_fails_with_invalid_name() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
alias 1234 = echo "test"
|
|
"#
|
|
));
|
|
assert!(actual
|
|
.err
|
|
.contains("alias name can't be a number, a filesize, or contain a hash"));
|
|
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
alias 5gib = echo "test"
|
|
"#
|
|
));
|
|
assert!(actual
|
|
.err
|
|
.contains("alias name can't be a number, a filesize, or contain a hash"));
|
|
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
alias "te#t" = echo "test"
|
|
"#
|
|
));
|
|
assert!(actual
|
|
.err
|
|
.contains("alias name can't be a number, a filesize, or contain a hash"));
|
|
}
|
|
|
|
#[test]
|
|
fn alias_alone_lists_aliases() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
alias a = 3; alias
|
|
"#
|
|
));
|
|
assert!(actual.out.contains("alias") && actual.out.contains("expansion"));
|
|
}
|