1
0
mirror of https://github.com/nushell/nushell.git synced 2025-03-22 03:27:30 +01:00
nushell/crates/nu_plugin_custom_values
Devyn Cairns c82dfce246
Fix deadlock on PluginCustomValue drop ()
# Description
Because the plugin interface reader thread can be responsible for
sending a drop notification, it's possible for it to end up in a
deadlock where it's waiting for the response to the drop notification
call.

I decided that the best way to address this is to just discard the
response and not wait for it. It's not really important to synchronize
with the response to `Dropped`, so this is probably faster anyway.

cc @ayax79, this is your issue where polars is getting stuck

# User-Facing Changes
- A bug fix
- Custom value plugin: `custom-value handle update` command

# Tests + Formatting

Tried to add a test with a long pipeline with a lot of drops and run it
over and over to reproduce the deadlock.

- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`
2024-04-05 21:57:00 -05:00
..
src Fix deadlock on PluginCustomValue drop () 2024-04-05 21:57:00 -05:00
Cargo.toml Bump version to 0.92.2 () 2024-04-05 10:24:00 -04:00